From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A7F6745F25;
	Mon, 23 Dec 2024 20:35:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3CDFE402C2;
	Mon, 23 Dec 2024 20:35:54 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 45BDA4029C
 for <dev@dpdk.org>; Mon, 23 Dec 2024 20:35:52 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 703E4206ADCE; Mon, 23 Dec 2024 11:35:51 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 703E4206ADCE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1734982551;
 bh=3GgQKzHqM4Wvio9CmJdNg1qEFL/iO85X8Nylfcossx0=;
 h=From:To:Cc:Subject:Date:From;
 b=MdinpIVx4k1r2R8MFh6o6qc/aFaUK2RPOa/UQmK2H16oRf05+ds5hJrpEDLz5sMoa
 S1W15q87pWjP7mzjtWGiMxwq5Z9cgHnQVO4FdKCxWDS2IakZpdgoeazxYpi7/Ipe6W
 lGGmt0nhjdknXnThPoNyS0rqS06PLNyI2dqpDAxs=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: 
Cc: dev@dpdk.org,
	Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH] app/test-cmdline: add test to Windows build
Date: Mon, 23 Dec 2024 11:35:41 -0800
Message-Id: <1734982541-8248-1-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Header termios.h was not found on Windows, which was probably the
reason this test was originally excluded from the Windows build.
However, ir turns out this header is not needed for this test, so it
can be removed and then test can be added to the Windows build
without negative consequences.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 app/test-cmdline/cmdline_test.c | 1 -
 app/test-cmdline/commands.c     | 1 -
 app/test-cmdline/meson.build    | 6 ------
 3 files changed, 8 deletions(-)

diff --git a/app/test-cmdline/cmdline_test.c b/app/test-cmdline/cmdline_test.c
index 89f4260cbf..21b4a4278d 100644
--- a/app/test-cmdline/cmdline_test.c
+++ b/app/test-cmdline/cmdline_test.c
@@ -8,7 +8,6 @@
 #include <stdarg.h>
 #include <stdlib.h>
 #include <errno.h>
-#include <termios.h>
 #include <ctype.h>
 #include <sys/queue.h>
 
diff --git a/app/test-cmdline/commands.c b/app/test-cmdline/commands.c
index a13e1d1afd..62b4e5dfa7 100644
--- a/app/test-cmdline/commands.c
+++ b/app/test-cmdline/commands.c
@@ -4,7 +4,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <termios.h>
 #include <inttypes.h>
 
 #include <rte_common.h>
diff --git a/app/test-cmdline/meson.build b/app/test-cmdline/meson.build
index 6027f67919..9d0a9aeb6e 100644
--- a/app/test-cmdline/meson.build
+++ b/app/test-cmdline/meson.build
@@ -1,11 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
 sources = files('commands.c', 'cmdline_test.c')
 deps += 'cmdline'
-- 
2.47.0.vfs.0.3