From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96A4F45F83; Tue, 31 Dec 2024 19:38:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0DD0402E2; Tue, 31 Dec 2024 19:38:33 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 19768402E2 for ; Tue, 31 Dec 2024 19:38:29 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 15B642046768; Tue, 31 Dec 2024 10:38:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 15B642046768 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1735670308; bh=3ekWtSALK3gQfJWH3X2Yo8WXWm/58vexga8abRMBaBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EDMgU/pE0+uEsNH3lLjMkd+XsQ9Hb7bXobYZyhAV9zDHgEUM1eaz9M7lx+lkuObLe tk+Na8SHptn9+qX/IRDI8XjvRt2Sfy+W0VPFCRCMD3LI6Ojh1DhyxqMQNd1lLyKnMK CTc7JABhdL1BfQGNP0bxt5ol5LpSmQBN/sOlPhmY= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v8 02/29] eal/include: add new packing macros Date: Tue, 31 Dec 2024 10:37:44 -0800 Message-Id: <1735670291-23224-3-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Add macro __rte_packed_begin which can be used to push existing pack value and set packing to 1-byte. Add macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Macro __rte_packed was marked as deprecated. Signed-off-by: Andre Muezerie Acked-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 4d299f2b36..40592f71b1 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -99,13 +99,32 @@ typedef uint32_t unaligned_uint32_t; typedef uint16_t unaligned_uint16_t; #endif +/** + * @deprecated + * @see __rte_packed_begin + * @see __rte_packed_end + * + * Force a structure to be packed + */ +#ifdef RTE_TOOLCHAIN_MSVC +#define __rte_packed RTE_DEPRECATED(__rte_packed) +#else +#define __rte_packed (RTE_DEPRECATED(__rte_packed) __attribute__((__packed__))) +#endif + /** * Force a structure to be packed + * Usage: + * struct __rte_packed_begin mystruct { ... } __rte_packed_end; + * union __rte_packed_begin myunion { ... } __rte_packed_end; + * Note: alignment attributes when present should precede __rte_packed_begin. */ #ifdef RTE_TOOLCHAIN_MSVC -#define __rte_packed +#define __rte_packed_begin __pragma(pack(push, 1)) +#define __rte_packed_end __pragma(pack(pop)) #else -#define __rte_packed __attribute__((__packed__)) +#define __rte_packed_begin +#define __rte_packed_end __attribute__((__packed__)) #endif /** -- 2.47.0.vfs.0.3