From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C87A45FD7; Fri, 3 Jan 2025 16:37:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F19314060B; Fri, 3 Jan 2025 16:37:02 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 402EF402D6 for ; Fri, 3 Jan 2025 16:36:59 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 4DE562041AA5; Fri, 3 Jan 2025 07:36:58 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4DE562041AA5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1735918618; bh=V83YvsOwDMhnD255wgzl7u7uxu5VXqmcRB+g06a+isc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=btXJqwGD2Y2X4itkyTUS/tV5XaAMuUJ9lEZm680N/ffuAhnCW4rqnD6NQqEfJKknl RxNVNdN4sebw4jPJarWI8Cn7iwrefho/VemT7pTLm+t8BVOxkRReZeybpJ1PRetwPu 0g6IfHMeWgCcF8e2efPIB/4cQZku8ava2R5rvu0Y= From: Andre Muezerie To: andremue@linux.microsoft.com Cc: dev@dpdk.org, stephen@networkplumber.org Subject: [PATCH v11 0/3] add diagnostics macros to make code portable Date: Fri, 3 Jan 2025 07:36:48 -0800 Message-Id: <1735918611-17374-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonyms for Clang (https://clang.llvm.org/docs/UsersManual.html). Now that effort is being made to make the code compatible with MSVC these expressions would become more complex. It makes sense to hide this complexity behind macros. This makes maintenance easier as these macros are defined in a single place. As a plus the code becomes more readable as well. v11: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v10: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v9: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v8: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v7: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v6: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v5: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v4: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v3: * Added __rte_diagnostic_ignored_wcast_qual to a few more places where it was needed. v2: * Removed __rte_diagnostic_ignored_wstrict_aliasing (introduced in v1). * Removed the pragmas from many files where they were not needed. * In the files where the pragmas were indeed needed, reduced the scope during which they are active, reducing the chance that unforeseen issues are hidden due to warning suppression. Andre Muezerie (3): lib/eal: add diagnostics macros to make code portable drivers/common: add diagnostics macros to make code portable drivers/net: add diagnostics macros to make code portable drivers/common/idpf/idpf_common_rxtx_avx512.c | 46 +++++++++++++++++-- drivers/net/axgbe/axgbe_rxtx.h | 9 ---- drivers/net/cpfl/cpfl_rxtx_vec_common.h | 4 -- drivers/net/dpaa2/dpaa2_rxtx.c | 16 ++----- drivers/net/fm10k/fm10k_rxtx_vec.c | 19 ++++++-- drivers/net/hns3/hns3_rxtx_vec_neon.h | 5 +- .../net/i40e/i40e_recycle_mbufs_vec_common.c | 2 - drivers/net/i40e/i40e_rxtx_common_avx.h | 16 +++++-- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 17 ++++++- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 16 +++++-- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 16 +++++-- drivers/net/i40e/i40e_rxtx_vec_common.h | 4 -- drivers/net/i40e/i40e_rxtx_vec_neon.c | 18 ++++++-- drivers/net/i40e/i40e_rxtx_vec_sse.c | 22 +++++++-- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 21 +++++++-- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 27 +++++++++-- drivers/net/iavf/iavf_rxtx_vec_common.h | 10 ++-- drivers/net/iavf/iavf_rxtx_vec_neon.c | 9 ++++ drivers/net/iavf/iavf_rxtx_vec_sse.c | 30 ++++++++++-- drivers/net/ice/ice_rxtx_common_avx.h | 16 +++++-- drivers/net/ice/ice_rxtx_vec_avx2.c | 16 +++++-- drivers/net/ice/ice_rxtx_vec_avx512.c | 16 +++++-- drivers/net/ice/ice_rxtx_vec_common.h | 4 -- drivers/net/ice/ice_rxtx_vec_sse.c | 22 +++++++-- drivers/net/idpf/idpf_rxtx_vec_common.h | 4 -- .../ixgbe/ixgbe_recycle_mbufs_vec_common.c | 2 - drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 14 +++++- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 19 ++++++-- drivers/net/mlx5/mlx5_flow.c | 6 +-- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 5 -- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 18 +++++--- drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 26 ++++++++--- drivers/net/ngbe/ngbe_rxtx_vec_neon.c | 9 ++++ drivers/net/tap/tap_flow.c | 6 +-- drivers/net/txgbe/txgbe_rxtx_vec_neon.c | 9 ++++ drivers/net/virtio/virtio_rxtx_simple.c | 4 -- lib/eal/include/rte_common.h | 23 ++++++++++ 37 files changed, 383 insertions(+), 143 deletions(-) -- 2.47.0.vfs.0.3