From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 966A446024;
Thu, 9 Jan 2025 01:51:49 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4079340673;
Thu, 9 Jan 2025 01:48:57 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id E5F27402EE
for <dev@dpdk.org>; Thu, 9 Jan 2025 01:48:41 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
id 76C23203E3BA; Wed, 8 Jan 2025 16:48:40 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 76C23203E3BA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1736383720;
bh=Shb59g4Yk/MoPcXnDvBq+0Ne5qI+2mK0T0wCwpo3aJA=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=HoVAbogU8zWMcWKZBcIgdzwExfKVAPJRojfWSC/Xha0Zl++CUMyzaZ2rAbJUA+SWu
2cQ+wg7ygowk2wzUVPiptpRlpZhF8zz5gBMjpmV3IRIyrMAVD22BBpdq6RrfLtsAsZ
utcCTNcbDOOkeheacL9OB3Pu4zI1QkQ7uifu59Ss=
From: Andre Muezerie <andremue@linux.microsoft.com>
To: roretzla@linux.microsoft.com
Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com,
bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com,
cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org,
dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com,
jingjing.wu@intel.com, kirill.rybalchenko@intel.com,
konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com,
orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com,
sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com,
stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com,
viacheslavo@nvidia.com, vladimir.medvedkin@intel.com,
yipeng1.wang@intel.com, Andre Muezerie <andremue@linux.microsoft.com>
Subject: [PATCH v9 13/30] drivers/mempool: replace packed attributes
Date: Wed, 8 Jan 2025 16:48:18 -0800
Message-Id: <1736383715-31703-14-git-send-email-andremue@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1736383715-31703-1-git-send-email-andremue@linux.microsoft.com>
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
<1736383715-31703-1-git-send-email-andremue@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
MSVC struct packing is not compatible with GCC. Replace macro
__rte_packed with __rte_packed_begin to push existing pack value
and set packing to 1-byte and macro __rte_packed_end to restore
the pack value prior to the push.
Macro __rte_packed_end is deliberately utilized to trigger a
MSVC compiler warning if no existing packing has been pushed allowing
easy identification of locations where the __rte_packed_begin is
missing.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
drivers/mempool/octeontx/octeontx_fpavf.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
index 966fee8bfe..6cd0fc057f 100644
--- a/drivers/mempool/octeontx/octeontx_fpavf.c
+++ b/drivers/mempool/octeontx/octeontx_fpavf.c
@@ -46,20 +46,20 @@ struct octeontx_mbox_fpa_cfg {
uint64_t aura_cfg;
};
-struct __rte_packed gen_req {
+struct __rte_packed_begin gen_req {
uint32_t value;
-};
+} __rte_packed_end;
-struct __rte_packed idn_req {
+struct __rte_packed_begin idn_req {
uint8_t domain_id;
-};
+} __rte_packed_end;
-struct __rte_packed gen_resp {
+struct __rte_packed_begin gen_resp {
uint16_t domain_id;
uint16_t vfid;
-};
+} __rte_packed_end;
-struct __rte_packed dcfg_resp {
+struct __rte_packed_begin dcfg_resp {
uint8_t sso_count;
uint8_t ssow_count;
uint8_t fpa_count;
@@ -67,7 +67,7 @@ struct __rte_packed dcfg_resp {
uint8_t tim_count;
uint8_t net_port_count;
uint8_t virt_port_count;
-};
+} __rte_packed_end;
#define FPA_MAX_POOL 32
#define FPA_PF_PAGE_SZ 4096
--
2.47.0.vfs.0.3