From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FEFE46025; Thu, 9 Jan 2025 03:47:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 898224060A; Thu, 9 Jan 2025 03:46:39 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BC890402EE for ; Thu, 9 Jan 2025 03:46:22 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 7A018206AB74; Wed, 8 Jan 2025 18:46:20 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7A018206AB74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736390781; bh=rO/ey1gAlqA3vdiy7QFr/aDhK93OK/wKiFHwKuijEEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hXLJ1/YQg9606YMGUKwHuSwWEZ+Izb4Bf126KNIN1YLlkYWzJ7zjWF+H1bRhFVW0U lFdRh2Yyen0CCzIXRYOI9+E/2URcHBrMsoP0AFiEO0ldORd6D4NS71Wf2jERIvgP0o hxVEbv8t1tja7kl4//PjQN2C5jOh8VYs3U0fhz0g= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v10 18/30] examples/common: replace packed attributes Date: Wed, 8 Jan 2025 18:46:02 -0800 Message-Id: <1736390774-14887-19-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Added parenthesis around *pnum in line __ rte_packed_end (*pnum) = (void *)pn; to avoid patch check error below: ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) 34: FILE: examples/common/neon/port_group.h:27: + } __ rte_packed_end *pnum = (void *)pn; With the parenthesis it becomes a warning, still not ideal, but better Running checkpatch.pl: WARNING:SPACING: space prohibited between function name and open parenthesis '(' 34: FILE: examples/common/neon/port_group.h:27: + } __ rte_packed_end (*pnum) = (void *)pn; Signed-off-by: Andre Muezerie --- examples/common/neon/port_group.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/common/neon/port_group.h b/examples/common/neon/port_group.h index 421e2e8613..b8f8be66e8 100644 --- a/examples/common/neon/port_group.h +++ b/examples/common/neon/port_group.h @@ -21,10 +21,10 @@ static inline uint16_t * port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t *lp, uint16x8_t dp1, uint16x8_t dp2) { - union { + union __rte_packed_begin { uint16_t u16[FWDSTEP + 1]; uint64_t u64; - } __rte_packed *pnum = (void *)pn; + } __rte_packed_end (*pnum) = (void *)pn; uint16x8_t mask = {1, 2, 4, 8, 0, 0, 0, 0}; int32_t v; -- 2.47.0.vfs.0.3