From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6AF846025; Thu, 9 Jan 2025 03:47:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48EC040674; Thu, 9 Jan 2025 03:46:35 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BC308402EA for ; Thu, 9 Jan 2025 03:46:22 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id A5B0B206AB77; Wed, 8 Jan 2025 18:46:20 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A5B0B206AB77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736390781; bh=RejUZVI6OPN9V3aUO1+DE58KhPkb8edycdig8NEeJhI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jgQ8OEe5xVfmsa6TzCFgPPPzCd6H+cE0iMjXUYgkISbgyiQT9Jr2sbPqJSTEuupXl /oW6STapxvMKQ77WG5pUp/F0RI2nHgRqIYbutwonHl+sAEYO4Yo9zZ0iKS9DLG9Aot H5dnFHOKcEC2F49OPNO+qJzECmq+7au2kShifRpE= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v10 21/30] examples/l3fwd-power: replace packed attributes Date: Wed, 8 Jan 2025 18:46:05 -0800 Message-Id: <1736390774-14887-22-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Signed-off-by: Andre Muezerie --- examples/l3fwd-power/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index ae8b55924e..d279e664b3 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -282,21 +282,21 @@ static struct rte_mempool * pktmbuf_pool[NB_SOCKETS]; #define DEFAULT_HASH_FUNC rte_jhash #endif -struct ipv4_5tuple { +struct __rte_packed_begin ipv4_5tuple { uint32_t ip_dst; uint32_t ip_src; uint16_t port_dst; uint16_t port_src; uint8_t proto; -} __rte_packed; +} __rte_packed_end; -struct ipv6_5tuple { +struct __rte_packed_begin ipv6_5tuple { uint8_t ip_dst[IPV6_ADDR_LEN]; uint8_t ip_src[IPV6_ADDR_LEN]; uint16_t port_dst; uint16_t port_src; uint8_t proto; -} __rte_packed; +} __rte_packed_end; struct ipv4_l3fwd_route { struct ipv4_5tuple key; -- 2.47.0.vfs.0.3