From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21F4846025; Thu, 9 Jan 2025 03:46:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D3B54064A; Thu, 9 Jan 2025 03:46:23 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 30F154025E for ; Thu, 9 Jan 2025 03:46:21 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 419BE203E3B1; Wed, 8 Jan 2025 18:46:20 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 419BE203E3B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736390780; bh=Nfe7Qk/qbT9gseJuwSL/89ekFUv9fUAiuPR55uXbla4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JBsCneFkMLao0uIxlsky14MRPVU8uV9v/OIsI2TWw01Hvr0gh7HZP2q9Cc6BzuJX6 ZB7gbrP5VIHby9+94AV6jQ+JiSkDkBf4mgdgPCqixKXsEDnWZlE2NNMjFdb9lxyb+p vLi+kME4MeyPP/P1msmPPsKbS49c6Q7fkiXtSqz8= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v10 02/30] eal/include: add new packing macros Date: Wed, 8 Jan 2025 18:45:46 -0800 Message-Id: <1736390774-14887-3-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1736390774-14887-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Add macro __rte_packed_begin which can be used to push existing pack value and set packing to 1-byte. Add macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Signed-off-by: Andre Muezerie Acked-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 4d299f2b36..d72f8590bd 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -101,11 +101,17 @@ typedef uint16_t unaligned_uint16_t; /** * Force a structure to be packed + * Usage: + * struct __rte_packed_begin mystruct { ... } __rte_packed_end; + * union __rte_packed_begin myunion { ... } __rte_packed_end; + * Note: alignment attributes when present should precede __rte_packed_begin. */ #ifdef RTE_TOOLCHAIN_MSVC -#define __rte_packed +#define __rte_packed_begin __pragma(pack(push, 1)) +#define __rte_packed_end __pragma(pack(pop)) #else -#define __rte_packed __attribute__((__packed__)) +#define __rte_packed_begin +#define __rte_packed_end __attribute__((__packed__)) #endif /** -- 2.47.0.vfs.0.3