From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 219DE4605F; Fri, 10 Jan 2025 21:25:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D34C54281D; Fri, 10 Jan 2025 21:24:20 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 29CC8427B9 for ; Fri, 10 Jan 2025 21:24:01 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id D2D2D203D605; Fri, 10 Jan 2025 12:23:59 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D2D2D203D605 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736540639; bh=uhBpJkPqZmW5vwtUf6rbbVnKmEl8IeiOVPPMABmYRKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F+nAcKjH5T9XS11cvv3ayzNZr+BQWUrS1XmU3O66redwJQzKe5ffVPwDcr/FUCEEx dJ3veiouL69+QBKDwVs8lNoZ+FmxLLsB8pIWucSNRUTVqgYDpqgbxymUKtUrZSJkh7 cpIBtPqW7+1tVQzy96t0ifzZ+DMJu6A79VIF/zxg= From: Andre Muezerie To: dev@dpdk.org Cc: konstantin.ananyev@huawei.com, homas@monjalon.net, david.marchand@redhat.com, Andre Muezerie Subject: [PATCH v14 20/81] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Date: Fri, 10 Jan 2025 12:22:39 -0800 Message-Id: <1736540620-21764-21-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736540620-21764-1-git-send-email-andremue@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1736540620-21764-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie Acked-by: Chengwen Feng --- app/test-pmd/meson.build | 10 +++++++++- app/test-pmd/shared_rxq_fwd.c | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index f1c36529b4..efd1eab0b0 100644 --- a/app/test-pmd/meson.build +++ b/app/test-pmd/meson.build @@ -3,7 +3,15 @@ # override default name to drop the hyphen name = 'testpmd' -cflags += '-Wno-deprecated-declarations' + +warning_flags = ['-Wno-deprecated-declarations', '-Wvla'] + +foreach arg: warning_flags + if cc.has_argument(arg) + cflags += arg + endif +endforeach + sources = files( '5tswap.c', 'cmdline.c', diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c index 623d62da88..b85830b90e 100644 --- a/app/test-pmd/shared_rxq_fwd.c +++ b/app/test-pmd/shared_rxq_fwd.c @@ -92,7 +92,7 @@ forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx, static bool shared_rxq_fwd(struct fwd_stream *fs) { - struct rte_mbuf *pkts_burst[nb_pkt_per_burst]; + struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; uint16_t nb_rx; nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst); -- 2.47.0.vfs.0.3