From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4562446079; Tue, 14 Jan 2025 02:27:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E982F40A7D; Tue, 14 Jan 2025 02:24:25 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B1BAE4064F for ; Tue, 14 Jan 2025 02:23:38 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 1BD8A203D606; Mon, 13 Jan 2025 17:23:36 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1BD8A203D606 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736817817; bh=4WHqxQLb4OUh+G0MkcdrV4eyHqnQyexpUndGzV7vrbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RG9Xpd/ZUfEcdsvZMIqumTE2oYAKT/BbWkqdRfPCqsxxhrMZQwBNyVwDdzbVPFc6b HSwPcf5hCLRUVQ2AHKDvw+BO19rrcOWVnBgImPlr9S495tHTw1lddHv4CJb4vDfBhL 3nKu3eoQUoVLzJeFsoyy2S83+yi2lAqk+HyxYi1g= From: Andre Muezerie To: dev@dpdk.org Cc: konstantin.ananyev@huawei.com, thomas@monjalon.net, david.marchand@redhat.com, Andre Muezerie Subject: [PATCH v15 34/60] drivers/common: add compile warning about use of VLAs Date: Mon, 13 Jan 2025 17:22:46 -0800 Message-Id: <1736817792-24967-35-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736817792-24967-1-git-send-email-andremue@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1736817792-24967-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/common/nfp/meson.build | 8 ++++++++ drivers/common/nitrox/meson.build | 8 ++++++++ drivers/common/sfc_efx/meson.build | 1 + 3 files changed, 17 insertions(+) diff --git a/drivers/common/nfp/meson.build b/drivers/common/nfp/meson.build index a09d1e25e2..165be4a868 100644 --- a/drivers/common/nfp/meson.build +++ b/drivers/common/nfp/meson.build @@ -14,3 +14,11 @@ sources = files( ) deps += ['bus_pci', 'net'] + +extra_flags = ['-Wvla'] + +foreach arg: extra_flags + if cc.has_argument(arg) + cflags += arg + endif +endforeach diff --git a/drivers/common/nitrox/meson.build b/drivers/common/nitrox/meson.build index f3cb42f006..46cd8ba65c 100644 --- a/drivers/common/nitrox/meson.build +++ b/drivers/common/nitrox/meson.build @@ -17,3 +17,11 @@ sources += files( includes += include_directories('../../crypto/nitrox') includes += include_directories('../../compress/nitrox') + +extra_flags = ['-Wvla'] + +foreach arg: extra_flags + if cc.has_argument(arg) + cflags += arg + endif +endforeach diff --git a/drivers/common/sfc_efx/meson.build b/drivers/common/sfc_efx/meson.build index 0cf0a23bf8..e3b90f670a 100644 --- a/drivers/common/sfc_efx/meson.build +++ b/drivers/common/sfc_efx/meson.build @@ -26,6 +26,7 @@ extra_flags += [ extra_flags += [ '-Waggregate-return', '-Wbad-function-cast', + '-Wvla', ] foreach flag: extra_flags -- 2.47.0.vfs.0.3