From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C10546085; Wed, 15 Jan 2025 05:27:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55FD34025F; Wed, 15 Jan 2025 05:27:26 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7CD85402A0 for ; Wed, 15 Jan 2025 05:27:24 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 867662043F30; Tue, 14 Jan 2025 20:27:23 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 867662043F30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736915243; bh=eTKBEhQXaOQ2GDPrtkTLBtXsaMKj7fkuOmsy1HZ4+hs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N+bT9DtSH3a88qS0dEdCLJ5wRM/udemRHdWDQYuS+vktqsHvmt4dIm2TONTLKjVk6 e8kVQcPrN5LBuKxQ5C8PiJWf3n4C1ASzOFPPBNMzSPZ1ZUPisW5MC/w91jfS7mGMmy ganl9dsLLB/+atTXQZWOgQ5iFJ7ILsMJjM0bhPOU= From: Andre Muezerie To: andremue@linux.microsoft.com Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com Subject: [PATCH v12 1/3] lib/eal: add diagnostics macros to make code portable Date: Tue, 14 Jan 2025 20:27:16 -0800 Message-Id: <1736915238-779-2-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736915238-779-1-git-send-email-andremue@linux.microsoft.com> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1736915238-779-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonyms for Clang (https://clang.llvm.org/docs/UsersManual.html). Now that effort is being made to make the code compatible with MSVC these expressions would become more complex. It makes sense to hide this complexity behind macros. This makes maintenance easier as these macros are defined in a single place. As a plus the code becomes more readable as well. Signed-off-by: Andre Muezerie --- lib/eal/include/rte_common.h | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 4d299f2b36..2142dd968d 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -137,6 +137,32 @@ typedef uint16_t unaligned_uint16_t; #define RTE_DEPRECATED(x) #endif +/* + * Macro to ignore whenever a pointer is cast so as to remove a type + * qualifier from the target type. + */ +#if !defined __INTEL_COMPILER && !defined RTE_TOOLCHAIN_MSVC +#define __rte_diagnostic_ignored_wcast_qual \ + _Pragma("GCC diagnostic ignored \"-Wcast-qual\"") +#else +#define __rte_diagnostic_ignored_wcast_qual +#endif + +/* + * Macros to cause the compiler to remember the state of the diagnostics as of + * each push, and restore to that point at each pop. + */ +#if !defined __INTEL_COMPILER && !defined RTE_TOOLCHAIN_MSVC +#define __rte_diagnostic_push _Pragma("GCC diagnostic push") +#define __rte_diagnostic_pop _Pragma("GCC diagnostic pop") +#else +#define __rte_diagnostic_push +#define __rte_diagnostic_pop +#endif + +#define RTE_IGNORE_CAST_QUAL(X) \ + ((uintptr_t)(X)) + /** * Mark a function or variable to a weak reference. */ -- 2.47.0.vfs.0.3