From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC61D46096; Thu, 16 Jan 2025 02:59:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D2304025F; Thu, 16 Jan 2025 02:59:35 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B99444025F for ; Thu, 16 Jan 2025 02:59:33 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id EE75720BEBFC; Wed, 15 Jan 2025 17:59:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EE75720BEBFC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736992772; bh=BpEB3dkp+mN+RvixWvWdH2ixU22KZVHKGljoTfmmj4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f5IO60T9i6pUBeJrgxoH/48sPNGnC0pYWFLwmvLdWvuaJBE1szIrG2ceHNHjVZ/PZ CFWnd1tcuquwF+16qLCQXmLD1PYxQGxFW0jjV65GCEmG1MUH48MLQh5kNYnjqeVhSY rH46BA9Tn7JhbYY/2UPGChwBRwSRmbAfdNAj6ZKA= From: Andre Muezerie To: andremue@linux.microsoft.com Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com Subject: [PATCH v13 1/3] eal: add diagnostics macros to make code portable Date: Wed, 15 Jan 2025 17:55:09 -0800 Message-Id: <1736992511-20462-2-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1736992511-20462-1-git-send-email-andremue@linux.microsoft.com> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1736992511-20462-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonyms for Clang (https://clang.llvm.org/docs/UsersManual.html). Now that effort is being made to make the code compatible with MSVC these expressions would become more complex. It makes sense to hide this complexity behind macros. This makes maintenance easier as these macros are defined in a single place. As a plus the code becomes more readable as well. Signed-off-by: Andre Muezerie --- lib/eal/include/rte_common.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 40592f71b1..8ddab43ec0 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -156,6 +156,35 @@ typedef uint16_t unaligned_uint16_t; #define RTE_DEPRECATED(x) #endif +/* + * Macros to cause the compiler to remember the state of the diagnostics as of + * each push, and restore to that point at each pop. + */ +#if !defined(__INTEL_COMPILER) && !defined(RTE_TOOLCHAIN_MSVC) +#define __rte_diagnostic_push _Pragma("GCC diagnostic push") +#define __rte_diagnostic_pop _Pragma("GCC diagnostic pop") +#else +#define __rte_diagnostic_push +#define __rte_diagnostic_pop +#endif + +/* + * Macro to disable compiler warnings about removing a type + * qualifier from the target type. + */ +#if !defined(__INTEL_COMPILER) && !defined(RTE_TOOLCHAIN_MSVC) +#define __rte_diagnostic_ignored_wcast_qual \ + _Pragma("GCC diagnostic ignored \"-Wcast-qual\"") +#else +#define __rte_diagnostic_ignored_wcast_qual +#endif + +/* + * Macro to disable compiler warnings about removing a type + * qualifier from a pointer. + */ +#define RTE_PTR_DROP_QUALIFIERS(X) ((void *)(uintptr_t)(X)) + /** * Mark a function or variable to a weak reference. */ -- 2.47.2.vfs.0.0