From: Andre Muezerie <andremue@linux.microsoft.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Farah Smith <farah.smith@broadcom.com>,
Shahaji Bhosle <sbhosle@broadcom.com>,
Peter Spreadborough <peter.spreadborough@broadcom.com>
Cc: dev@dpdk.org, Andre Muezerie <andremue@linux.microsoft.com>,
stable@dpdk.org
Subject: [PATCH] drivers/net: fix indication of allocation
Date: Fri, 17 Jan 2025 12:51:33 -0800 [thread overview]
Message-ID: <1737147093-11172-1-git-send-email-andremue@linux.microsoft.com> (raw)
When experimenting with the -std=c2x compiler option the error below
popped up:
../drivers/net/bnxt/tf_core/tf_sram_mgr.c:952:39: error: incompatible
types when assigning to type ‘_Bool *’ from type ‘_Bool’
The code indicates that the intention was to assign false to the bool
being pointed to, not to the pointer itself.
Fixes: 37ff91c158a3 ("net/bnxt: add SRAM manager model")
Cc: stable@dpdk.org
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
drivers/net/bnxt/tf_core/tf_sram_mgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/tf_core/tf_sram_mgr.c b/drivers/net/bnxt/tf_core/tf_sram_mgr.c
index 87e8882fed..0dffd74cd5 100644
--- a/drivers/net/bnxt/tf_core/tf_sram_mgr.c
+++ b/drivers/net/bnxt/tf_core/tf_sram_mgr.c
@@ -949,7 +949,7 @@ int tf_sram_mgr_is_allocated(void *sram_handle,
tf_sram_slice_2_str(parms->slice_size),
tf_sram_bank_2_str(parms->bank_id));
- parms->is_allocated = false;
+ *parms->is_allocated = false;
goto done;
}
@@ -964,7 +964,7 @@ int tf_sram_mgr_is_allocated(void *sram_handle,
if (block == NULL) {
TFP_DRV_LOG(ERR, "block not found in list 0x%x\n",
parms->sram_offset);
- parms->is_allocated = false;
+ *parms->is_allocated = false;
goto done;
}
--
2.47.2.vfs.0.1
reply other threads:[~2025-01-17 20:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1737147093-11172-1-git-send-email-andremue@linux.microsoft.com \
--to=andremue@linux.microsoft.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=farah.smith@broadcom.com \
--cc=peter.spreadborough@broadcom.com \
--cc=sbhosle@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).