From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E042A0597; Thu, 9 Apr 2020 12:59:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F8871C22F; Thu, 9 Apr 2020 12:59:56 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id DC1F11C22B for ; Thu, 9 Apr 2020 12:59:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 6A90F842; Thu, 9 Apr 2020 06:59:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 09 Apr 2020 06:59:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mMaD4umuZCwHsEFmbc6oqRJhZ9SgWXb1W1QCSK49apw=; b=sGO+t9xb3lgk XLDLwC2QPwTxCBgzNn0mVVcDSop8d5m3IOkz/rtn+u6booxySuqD38y9siaEElGJ itwdBVb+ocVXb8MxdC1ifKISrV88hpkacQpL6gzLi2odnPHhyRqKPHGV1axWQl9z 4SeDSHfbiqH/Cd5RqeWAvMrNciNkdkQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=mMaD4umuZCwHsEFmbc6oqRJhZ9SgWXb1W1QCSK49a pw=; b=OEvdrA0ZwLG3LkVZyrCnGIdKD3Pi5Wvcr/GGRkSL1xl/5KQB2mBr+h2cp VYW9djCV/L4JIOt7nGSB2Q8n95GfmG5i5dqeWDU+a31Hl9cZG8DIXEUu1+4OZpoH mISaz9mamYWSSLhpCSk33OJZb43Kr9KyEItYhou3HG5KYjLhfF1vzLMrNzjN7KL9 ylKk2YIVbvlgE4MpCjCvijQkiLz011HqFg6S2HZ8Jg72caZo2FOjasGnO33lsIqO /5OdYLjF4l75BoxvToofnAGRhAiLwZ729BA/vWLzoXfbu6FZYVd3mgIiYDweCd3K bgPA49NjQqeiiGxCX2sEFwsh+Zm7A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9AD0F3060057; Thu, 9 Apr 2020 06:59:51 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Neil Horman , Ray Kinsella Cc: dev@dpdk.org, david.marchand@redhat.com Date: Thu, 09 Apr 2020 12:59:50 +0200 Message-ID: <1737651.3VsfAaAtOV@thomas> In-Reply-To: <926b5dce-1904-5fbf-39ce-8c08661b83d1@ashroe.eu> References: <20200408195616.335004-1-nhorman@tuxdriver.com> <20200409104317.GB613@bricha3-MOBL.ger.corp.intel.com> <926b5dce-1904-5fbf-39ce-8c08661b83d1@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/04/2020 12:45, Ray Kinsella: > On 09/04/2020 11:43, Bruce Richardson wrote: > > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > >> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > >>> On 08/04/2020 20:56, Neil Horman wrote: > >>>> +The syntax of the ``check-abi.sh`` utility is:: > >>>> + > >>>> + ./devtools/check-abi.sh > >>> > >>> (from v1 feedback) > >>> Could we simplify this all greatly, by telling people to use the meson/ninja build, > >>> so they get this checking out of the box, without all the headache below? > >>> > >> I think bruce noted that was never merged, correct? > >> > > Yep, correct. :-( > > apologies, was there a reason? Because build tool job is building, not checking. It would be wrong to make (slow) checks mandatory in all builds. The need is to enforce checking ABI. The result is already published by Travis in patchwork and in an email to the author I believe. Not checking email and patchwork is not a good excuse. Patchwork must be a mandatory read for everybody for all checks in general. Let's not give up on general CI workflow.