From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: dev@dpdk.org, fanzhang.oss@gmail.com, gakhil@marvell.com,
mb@smartsharesystems.com
Subject: [PATCH v2 1/2] lib/cryptodev: avoid implicit conversion to 64 bit number
Date: Mon, 27 Jan 2025 08:03:52 -0800 [thread overview]
Message-ID: <1737993833-22957-1-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1732758837-6350-1-git-send-email-andremue@linux.microsoft.com>
MSVC issues the warning below:
../lib/cryptodev/rte_cryptodev.c(623): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)
The code would be better off by using 64 bit numbers to begin with.
That eliminates the need for a conversion to 64 bits later.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
lib/cryptodev/rte_cryptodev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 85a4b46ac9..a49b0662f3 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -620,7 +620,7 @@ rte_cryptodev_asym_xform_capability_check_hash(
{
bool ret = false;
- if (capability->hash_algos & (1 << hash))
+ if (capability->hash_algos & RTE_BIT64(hash))
ret = true;
rte_cryptodev_trace_asym_xform_capability_check_hash(
--
2.47.2.vfs.0.1
next prev parent reply other threads:[~2025-01-27 16:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 1:53 [PATCH " Andre Muezerie
2024-11-28 1:53 ` [PATCH 2/2] lib/hash: " Andre Muezerie
2025-01-22 16:12 ` Bruce Richardson
2025-01-22 21:36 ` Andre Muezerie
2025-01-23 7:55 ` Morten Brørup
2025-01-23 17:42 ` Andre Muezerie
2025-01-25 12:56 ` Morten Brørup
2025-01-22 16:15 ` Medvedkin, Vladimir
2025-01-08 10:28 ` [EXTERNAL] [PATCH 1/2] lib/cryptodev: " Akhil Goyal
2025-01-27 16:03 ` Andre Muezerie [this message]
2025-01-27 16:03 ` [PATCH v2 2/2] lib/hash: " Andre Muezerie
2025-01-27 17:16 ` Morten Brørup
2025-01-27 17:14 ` [PATCH v2 1/2] lib/cryptodev: " Morten Brørup
2025-01-27 19:36 ` Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 1/3] " Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 2/3] lib/hash: " Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 3/3] drivers/crypto: use RTE_BIT64 in initializations of hash_algos Andre Muezerie
2025-01-28 7:45 ` Morten Brørup
2025-01-28 7:49 ` Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1737993833-22957-1-git-send-email-andremue@linux.microsoft.com \
--to=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).