DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	ShuaiX Zhu <shuaix.zhu@intel.com>,
	Xueqin Lin <xueqin.lin@intel.com>,
	WenjieX A Li <wenjiex.a.li@intel.com>,
	FengqinX Wang <fengqinx.wang@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid
Date: Sat, 26 Jan 2019 19:20:02 +0100	[thread overview]
Message-ID: <1738923.4uAXThKVLp@xps> (raw)
In-Reply-To: <0937580d-ddbf-f1f2-a6e2-e0d6dad0f33d@intel.com>

25/01/2019 15:12, Burakov, Anatoly:
> On 25-Jan-19 2:00 PM, Ilya Maximets wrote:
> > On 25.01.2019 16:48, Burakov, Anatoly wrote:
> >> On 25-Jan-19 9:53 AM, David Marchand wrote:
> >>>
> >>> Reviewed-by: David Marchand <david.marchand@redhat.com <mailto:david.marchand@redhat.com>>
> >>
> >> Now that i think of it, maybe it's not that simple.
> >>
> >> --socket-mem/-m flag with zero is still an invalid value *if* --legacy-mem is involved. However, it is a valid value in non-legacy mode.
> >>
> >> So maybe the test should reflect this, and the previous fix should have instead added a check for legacy mode rather than disabling the zero check outright.
> >>
> > 
> > I don't think that it's a big deal, because "--socket-mem=0 --legacy-mem"
> > quickly fails with clear:
> > 
> >    EAL: WARNING: Master core has no memory on local socket!
> > 
> > IMHO, It's actually more informative than previous:
> > 
> >    EAL: invalid parameters for --socket-limit
> > 
> > I agree that we could add a test for a legacy-mem cases, but that's a bit
> > different task.
> 
> Good point. Maybe leave it as is then :)
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks

      reply	other threads:[~2019-01-26 18:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190125075604eucas1p2ecf0177c3f953e889721d784ef387254@eucas1p2.samsung.com>
2019-01-25  7:55 ` Ilya Maximets
2019-01-25  8:06   ` Ilya Maximets
2019-01-25  9:53     ` David Marchand
2019-01-25 13:48       ` Burakov, Anatoly
2019-01-25 14:00         ` Ilya Maximets
2019-01-25 14:12           ` Burakov, Anatoly
2019-01-26 18:20             ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1738923.4uAXThKVLp@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fengqinx.wang@intel.com \
    --cc=i.maximets@samsung.com \
    --cc=shuaix.zhu@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).