DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] telemetry: detach pthreads
@ 2021-08-19  2:38 Stephen Hemminger
  2021-08-20  8:49 ` Power, Ciara
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2021-08-19  2:38 UTC (permalink / raw)
  To: ciara.power; +Cc: dev, Stephen Hemminger

There are a number telemetry threads which are created and
there is nothing that does pthread_join() to wait for them.
Mark these threads as detached, so that the pthread library
can cleanup state when the thread exits.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/telemetry/telemetry.c        | 2 ++
 lib/telemetry/telemetry_legacy.c | 1 +
 2 files changed, 3 insertions(+)

diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 8665db8d035b..976f0a21566e 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -490,6 +490,7 @@ telemetry_legacy_init(void)
 	pthread_setaffinity_np(t_old, sizeof(*thread_cpuset), thread_cpuset);
 	set_thread_name(t_old, "telemetry-v1");
 	TMTY_LOG(DEBUG, "Legacy telemetry socket initialized ok\n");
+	pthread_detach(t_old);
 	return 0;
 }
 
@@ -528,6 +529,7 @@ telemetry_v2_init(void)
 	}
 	pthread_setaffinity_np(t_new, sizeof(*thread_cpuset), thread_cpuset);
 	set_thread_name(t_new, "telemetry-v2");
+	pthread_detach(t_new);
 	atexit(unlink_sockets);
 
 	return 0;
diff --git a/lib/telemetry/telemetry_legacy.c b/lib/telemetry/telemetry_legacy.c
index b7cd1bdd6c7b..8aba44d689b7 100644
--- a/lib/telemetry/telemetry_legacy.c
+++ b/lib/telemetry/telemetry_legacy.c
@@ -121,6 +121,7 @@ register_client(const char *cmd __rte_unused, const char *params,
 		close(fd);
 		return -1;
 	}
+	pthread_detach(th);
 #endif /* !RTE_EXEC_ENV_WINDOWS */
 	return 0;
 }
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] telemetry: detach pthreads
  2021-08-19  2:38 [dpdk-dev] [PATCH] telemetry: detach pthreads Stephen Hemminger
@ 2021-08-20  8:49 ` Power, Ciara
  2021-10-01 12:50   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Power, Ciara @ 2021-08-20  8:49 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Richardson, Bruce

Hi Stephen,

>-----Original Message-----
>From: Stephen Hemminger <stephen@networkplumber.org>
>Sent: Thursday 19 August 2021 03:38
>To: Power, Ciara <ciara.power@intel.com>
>Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>
>Subject: [PATCH] telemetry: detach pthreads
>
>There are a number telemetry threads which are created and there is nothing
>that does pthread_join() to wait for them.
>Mark these threads as detached, so that the pthread library can cleanup state
>when the thread exits.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
> lib/telemetry/telemetry.c        | 2 ++
> lib/telemetry/telemetry_legacy.c | 1 +
> 2 files changed, 3 insertions(+)
>
<snip>

Thanks for catching this,

Acked-by: Ciara Power <ciara.power@intel.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] telemetry: detach pthreads
  2021-08-20  8:49 ` Power, Ciara
@ 2021-10-01 12:50   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-10-01 12:50 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Richardson, Bruce, Power, Ciara

> >There are a number telemetry threads which are created and there is nothing
> >that does pthread_join() to wait for them.
> >Mark these threads as detached, so that the pthread library can cleanup state
> >when the thread exits.
> >
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >---
> > lib/telemetry/telemetry.c        | 2 ++
> > lib/telemetry/telemetry_legacy.c | 1 +
> > 2 files changed, 3 insertions(+)
> >
> <snip>
> 
> Thanks for catching this,
> 
> Acked-by: Ciara Power <ciara.power@intel.com>

Applied, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-01 12:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19  2:38 [dpdk-dev] [PATCH] telemetry: detach pthreads Stephen Hemminger
2021-08-20  8:49 ` Power, Ciara
2021-10-01 12:50   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).