DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, jianfeng.tan@intel.com
Cc: dev@dpdk.org, bluca@debian.org
Subject: Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list
Date: Fri, 3 Nov 2017 11:34:53 +0000	[thread overview]
Message-ID: <173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com> (raw)
In-Reply-To: <20171103112455.18406-1-thomas@monjalon.net>

Hi Thomas,

I reckon you need to bump ABI version when you remove public symbol from 
.map file.

Thanks,
Sergio

On 03/11/2017 11:24, Thomas Monjalon wrote:
> The function rte_mem_phy2mch() was removed with the support
> of Xen dom0.
>
> Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>   lib/librte_eal/rte_eal_version.map | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index d2a4ff974..7c9bdc2ae 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -62,7 +62,6 @@ DPDK_2.0 {
>   	rte_malloc_validate;
>   	rte_malloc_virt2phy;
>   	rte_mem_lock_page;
> -	rte_mem_phy2mch;
>   	rte_mem_virt2phy;
>   	rte_memdump;
>   	rte_memory_get_nchannel;

  reply	other threads:[~2017-11-03 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 11:24 Thomas Monjalon
2017-11-03 11:34 ` Gonzalez Monroy, Sergio [this message]
2017-11-03 13:52   ` Thomas Monjalon
2017-11-06 21:15 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com \
    --to=sergio.gonzalez.monroy@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).