From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 9243C1B67A
for <dev@dpdk.org>; Fri, 3 Nov 2017 12:34:56 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
03 Nov 2017 04:34:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,338,1505804400"; d="scan'208";a="171554959"
Received: from smonroy-mobl.ger.corp.intel.com (HELO [10.237.220.37])
([10.237.220.37])
by fmsmga006.fm.intel.com with ESMTP; 03 Nov 2017 04:34:54 -0700
To: Thomas Monjalon <thomas@monjalon.net>, jianfeng.tan@intel.com
Cc: dev@dpdk.org, bluca@debian.org
References: <20171103112455.18406-1-thomas@monjalon.net>
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Message-ID: <173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com>
Date: Fri, 3 Nov 2017 11:34:53 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171103112455.18406-1-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] mem: remove old function from symbol list
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Nov 2017 11:34:57 -0000
Hi Thomas,
I reckon you need to bump ABI version when you remove public symbol from
.map file.
Thanks,
Sergio
On 03/11/2017 11:24, Thomas Monjalon wrote:
> The function rte_mem_phy2mch() was removed with the support
> of Xen dom0.
>
> Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> lib/librte_eal/rte_eal_version.map | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index d2a4ff974..7c9bdc2ae 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -62,7 +62,6 @@ DPDK_2.0 {
> rte_malloc_validate;
> rte_malloc_virt2phy;
> rte_mem_lock_page;
> - rte_mem_phy2mch;
> rte_mem_virt2phy;
> rte_memdump;
> rte_memory_get_nchannel;