From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57F4E43198; Wed, 18 Oct 2023 11:14:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D62C34027C; Wed, 18 Oct 2023 11:14:51 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id D5C9540151 for ; Wed, 18 Oct 2023 11:14:49 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D061D5C02B0; Wed, 18 Oct 2023 05:14:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 18 Oct 2023 05:14:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1697620486; x=1697706886; bh=XpPZPsGNL6wOpu6jUFUeJ7a0jokgKbrrDig MZWcROw0=; b=hBSRsaBOtbQKjOcjf2rW5XytRNZACFoTZigloQOaUH9aJlfnEWn +l3xrXYR5KRm5x5dL/Xkcj6d5/ECFS7ej+/EFG0NGMjt9fLsPKpjZ26Wq7RAlrLj 8tlCjTSE8h92NwBNQgp8WbgG+bztU78c2c+3rhRK/idcqfwVIzutiYSCKaGqCtvv 8J3tpJcQSeBfRzesX2BG2ZtkLSuiTMl7cMbDbNyGQnmIvk0uIL+APkqmhmZSlCjo 7/f69IbARzEeZaFJGW2/Ak994JSACiJtkcikEg1gtZQGQQyVS0a6pXH5/BCavzzd M9VhSvgzYSoQPApwwMNwVveqZZnYM1MpsWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697620486; x=1697706886; bh=XpPZPsGNL6wOpu6jUFUeJ7a0jokgKbrrDig MZWcROw0=; b=iV7wYiittCNgW+8SyiHsI/QJ/7kFz1vH0oDctfJDDzystzS9UYu vx1+qQNPtWLqLxS2zRncMDb7SXE9Zvh/E6BMn6rn86ReQ0qyIvzgvHA1v1Jf9fa8 3c+xNQz5jEY7U1zjJ9aBWdgQepgAAH2EmmAhJl6i8VuTlQz4lKxnGucfLusBYSEd TbJHdVbCZm/zbyUYzC029+5QAlC5UNTmXtRXXKJHMVIog+acslqgN4MIHqDw4uCz BfM6T0+5R8Nf87hl9fgK/41DiFEX9r+rbocN4wrvWqDDh2b2MFOhesi2BtUeQImW 8oRkQRzX9o4wJEn7vUukDV5i6g6nImSQXRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeeggdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Oct 2023 05:14:45 -0400 (EDT) From: Thomas Monjalon To: Robin Jarry , Sunil Kumar Kori Cc: "dev@dpdk.org" , Jerin Jacob Subject: Re: [EXT] Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key Date: Wed, 18 Oct 2023 11:14:44 +0200 Message-ID: <1741122.jNaZZp9DzI@thomas> In-Reply-To: References: <20231009163033.1095213-1-skori@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/10/2023 09:26, Sunil Kumar Kori: > From: Robin Jarry > > From: Sunil Kumar Kori > > > > > > This patch adds RSS key for CNXK platforms. CNXK platform uses > > > 48 bytes long key for hash calculations. > > > > > > For the same patch also updates help mesaages to provide range > > > information for supporting NICs/platforms. > > > > > > Also CNXK uses reta size as 64 so to get correct offset to retrieve > > > queue index, user must pass reta_size option as 64 i.e. -t 64. > > > > I think we should add some driver abstraction that contains the required key > > length and default reta size. Instead of requiring the user to guess the correct > > values. Is that something you could do? > > > Okay but in either case i.e. -t option or driver abstraction, user must know the reta size and key size before configuring. > So I am not sure that how adding driver abstraction will help to solve this issue unless/until its documented somewhere. You can start with an option to get the size printed, depending on driver name. > So for current release, I am planning to go this version as it is because we are close. > Later on we can think of it and add required support. > Please provide input on it. Please provide a more user friendly experience in this release.