From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7D55A0583; Fri, 20 Mar 2020 12:46:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 082D6F94; Fri, 20 Mar 2020 12:46:38 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 018CFF90 for ; Fri, 20 Mar 2020 12:46:35 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 574DB580259; Fri, 20 Mar 2020 07:46:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 20 Mar 2020 07:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=O/ocHB8IV6grmt1lqive+GR2LUuy8CN+o9hgK73PUhU=; b=jMl0cyqvBTS0 HeGMBtbPi2/9C7tQ/V/6A3a31HklzaU3Nte766nMxgCXF9VbQ7nlPwQTrBvMjL0F sg9BQCoO0jgEs8RN/Fj16YMxK+qiFTdYpvp3RcxPWR8/pDY2DxYv3EuSCK8jsQOj 2vx+cNzzSTBiQTRyfC4hl7Cw9E2803k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=O/ocHB8IV6grmt1lqive+GR2LUuy8CN+o9hgK73PU hU=; b=h/JO5MzgErDrjTDOc7yfpBHmz2FgYebxhiB3DsAS/GtrbYQmW9YmQR1Mu 3W1PJFua44i8iYYUI1eVVRAr776ldOaUBxcxJgyQkllICK92fMsmOQBdbu8SxpVT S6FW9DCox4d6LL2nQVD7mmVrJENdXmokIzg4cDrZP8KFUPCWupxadtMpYo7fgCHh +bTdOBxAaIIQ7GdnqzhwmTQH944r09NZ6C1HczI3Wk1qRZLOyJIFLhQUGeF+5gjA qW8aD4MGDlAVpG+udM6aoDH58t9C4VJTV8XyX4BsECOercXfoDWIB3UcTqghqV7q 5SdRV8jVOv9p1NfdfPdnjthuEUgqw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeguddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B1D6B3280067; Fri, 20 Mar 2020 07:46:27 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, Neil Horman , John McNamara , Marko Kovacevic , Hemant Agrawal , Sachin Saxena , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Gagandeep Singh , Akhil Goyal , Nipun Gupta , Maxime Coquelin , Zhihong Wang , Xiaolong Ye , Ferruh Yigit , Cristian Dumitrescu , Jan Viktorin , Gavin Hu , Jerin Jacob , Harry van Haaren , Anatoly Burakov , Phil Yang , Joyce Kong , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , David Christensen , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon , Konstantin Ananyev , Olivier Matz Date: Fri, 20 Mar 2020 12:46:26 +0100 Message-ID: <1741544.tdWV9SEqCh@xps> In-Reply-To: <20200320093418.GA1502@bricha3-MOBL.ger.corp.intel.com> References: <20200320001220.150235-1-thomas@monjalon.net> <20200320093418.GA1502@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: reorganize directories layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2020 10:34, Bruce Richardson: > On Fri, Mar 20, 2020 at 01:12:18AM +0100, Thomas Monjalon wrote: > > Some clean-up is done in EAL sub-directories. > > The goal is to make organization easier to understand, > > and to prepare moving some files from common to Unix-only place. > > > > Since the kernel modules are moved to kernel/ directory, > > there is no need anymore for the sub-directory eal/ in > > linux/, freebsd/ and windows/. > > > > The EAL API (with doxygen documentation) is moved from > > common/include/ to include/, which makes more clear that > > it is the global API for all environments and architectures. > > Note that the arch-specific and os-specific include files are not > > in this global include directory, but include/generic/ should > > cover the doxygen documentation for them. > > > > The arch-specific directories arm, ppc_64 and x86 in common/arch/ > > and in common/include/arch are moved at the same level as the > > os-specific directories, adding an include/ sub-directory. > > It makes more clear that EAL is covering a matrix combining OS and arch. > > Note that ppc_64 is renamed to ppc. > > > > These moves offer the opportunity to simplify the make and meson files. > > > > Signed-off-by: Thomas Monjalon > > > > --- > > > > This change was proposed to the Technical Board in advance: > > http://mails.dpdk.org/archives/dev/2020-January/156732.html > > > > If required, the patch may be split: > > 1/ remove FreeBSD kernel Makefile > > 2/ move arch .c files > > 3/ move arch .h files > > 4/ move common and generic includes > > 5/ move os/eal/ to os/ > > > > I've scanned through this patch and it is quite long. I like the idea of > cleanup, but I do think splitting would make reviewing easier, since it's > hard to track what is moving where all in one go. OK, I'll prepare a v2, split in 5 patches. Note: v1 is not compiling because I missed some "git add" in the include directory.