From: Thomas Monjalon <thomas@monjalon.net>
To: Jens Freimann <jfreimann@redhat.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"ailan@redhat.com" <ailan@redhat.com>,
"jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"ktraynor@redhat.com" <ktraynor@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour
Date: Tue, 02 Oct 2018 11:51:09 +0200 [thread overview]
Message-ID: <1742510.Ad7anXBEc8@xps> (raw)
In-Reply-To: <20181002085928.gmigdlq7v7wujnyf@jenstp.localdomain>
02/10/2018 10:59, Jens Freimann:
> On Tue, Oct 02, 2018 at 09:57:52AM +0200, Thomas Monjalon wrote:
> >02/10/2018 09:19, Jens Freimann:
> >> On Mon, Oct 01, 2018 at 01:13:32PM +0000, Iremonger, Bernard wrote:
> >> >./devtools/check-git-log.sh -1
> >> >Headline too long:
> >> > app/testpmd: add forwarding mode to simulate a noisy neighbour
> >>
> >> I'm sorry, I failed to use checkpatches.sh correctly :) I did:
> >>
> >> #> git show | DPDK_CHECKPATCH_PATH="/home/jfreiman/code/linux/scripts/checkpatch.pl" devtools/checkpatches.sh --
> >>
> >> 1/1 valid patch
> >
> >Why this command is not correct?
>
> checkpatches.sh looks for the string "Subject:" which is not included
> in git show output. Using cat on the patch file instead will work.
Yes indeed.
As an improvement, we could check for "git show" output, starting with "commit" word.
prev parent reply other threads:[~2018-10-02 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 13:26 Jens Freimann
2018-09-25 14:55 ` Kevin Traynor
2018-10-01 13:13 ` Iremonger, Bernard
2018-10-02 7:19 ` Jens Freimann
2018-10-02 7:57 ` Thomas Monjalon
2018-10-02 8:59 ` Jens Freimann
2018-10-02 9:51 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1742510.Ad7anXBEc8@xps \
--to=thomas@monjalon.net \
--cc=ailan@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jan.scheurich@ericsson.com \
--cc=jfreimann@redhat.com \
--cc=konstantin.ananyev@intel.com \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).