From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3EC6C200 for ; Tue, 2 Oct 2018 11:51:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D0E2721C86; Tue, 2 Oct 2018 05:51:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Oct 2018 05:51:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=QzMuO8u4rrxi3pzJ+ZPvINMwn1 HacSYtgdnfe35CFB0=; b=Kup/1u3T2a6aXj9InxdHom0Y2tvfI/Ta+wEK8Bi13g QUTkxLX0hGO2caGhgleb5jrlAVBWkxQ1fL1WiyvM+95yg8TnqVb0ksulj53Ee4Lh qBtiC0o6/ZmGkRGhrnOYqTHfgsrzp7zQ5H6LkIY1hSPjCHhbGMLTHEyUQv+Qqb9r s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=QzMuO8 u4rrxi3pzJ+ZPvINMwn1HacSYtgdnfe35CFB0=; b=fjhby4VWqpQi96kTBwdAHr WsyAA+bx+bLCS8lpnJygNceHRPjwyp9Jo+wP8puk6Ut7IuE19GdzuEw2Dat7mXpB YkW/IORUBegYlvMjPZXQmDSrze/liGk80o+SgH5jOWHST/hhq5gGatuPwz14c+GJ mR3DxDX4Wdi1s09pFqAyIbSbsFMvyliOfW16dGRHENS3JyIpoKMuqiQVHEAUwhSK m/zzMy1zzaLi/fFEEqry2HoaEkPN5r6U4n8UgtG/pTTVomijrHflSXEdHeiA4yP7 MQQhR2J0Ik4vUdH56p+b15OT+CB5Q+e56kyj9Aon7zg68U/aKEDR3z5Hh7l9LZBg == X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 149EBE4BC1; Tue, 2 Oct 2018 05:51:10 -0400 (EDT) From: Thomas Monjalon To: Jens Freimann Cc: "Iremonger, Bernard" , "dev@dpdk.org" , "ailan@redhat.com" , "jan.scheurich@ericsson.com" , "Richardson, Bruce" , "maxime.coquelin@redhat.com" , "Ananyev, Konstantin" , "Yigit, Ferruh" , "ktraynor@redhat.com" Date: Tue, 02 Oct 2018 11:51:09 +0200 Message-ID: <1742510.Ad7anXBEc8@xps> In-Reply-To: <20181002085928.gmigdlq7v7wujnyf@jenstp.localdomain> References: <20180921132633.21317-1-jfreimann@redhat.com> <5093277.B6gBP5p74m@xps> <20181002085928.gmigdlq7v7wujnyf@jenstp.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 09:51:13 -0000 02/10/2018 10:59, Jens Freimann: > On Tue, Oct 02, 2018 at 09:57:52AM +0200, Thomas Monjalon wrote: > >02/10/2018 09:19, Jens Freimann: > >> On Mon, Oct 01, 2018 at 01:13:32PM +0000, Iremonger, Bernard wrote: > >> >./devtools/check-git-log.sh -1 > >> >Headline too long: > >> > app/testpmd: add forwarding mode to simulate a noisy neighbour > >> > >> I'm sorry, I failed to use checkpatches.sh correctly :) I did: > >> > >> #> git show | DPDK_CHECKPATCH_PATH="/home/jfreiman/code/linux/scripts/checkpatch.pl" devtools/checkpatches.sh -- > >> > >> 1/1 valid patch > > > >Why this command is not correct? > > checkpatches.sh looks for the string "Subject:" which is not included > in git show output. Using cat on the patch file instead will work. Yes indeed. As an improvement, we could check for "git show" output, starting with "commit" word.