From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AF57DA04C1;
	Thu, 21 Nov 2019 22:22:34 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id F3F2D2BAF;
	Thu, 21 Nov 2019 22:22:33 +0100 (CET)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 032832BAE
 for <dev@dpdk.org>; Thu, 21 Nov 2019 22:22:32 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 7E50E22923;
 Thu, 21 Nov 2019 16:22:32 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 21 Nov 2019 16:22:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=1Wt6TBFznmBAIJv+i08rkVoWps3K7eMK0xwKTrp7Ywg=; b=mnbmGkp6dmr3
 zhhRMBthL3QwWDU/lZVkLnrWFHtvQfa5JKj8bjHxGu6Anq3OkezXlS/KYrePCSs4
 kZuVJjNpXQ8wF8MEajKMJggBOVERR5YkIM77hK/+I2A8AhRJBjWv9vUR8dansfT4
 9z9pEc2y4sqSFE/DoVjsEpZmjeDYIwE=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=1Wt6TBFznmBAIJv+i08rkVoWps3K7eMK0xwKTrp7Y
 wg=; b=OL3d77OhuPhh9il7X+8OdAUVa7IIxNR8l06Xik9iWq4S9hsASAIcTI9/r
 qwa8O16OOWRGaz4RHo/yObQkoCcGQ5ze+aBgVX8QRlX+kZ9zSVWOwye18iA+fbgJ
 m50mdiB1q1VWd3C8u0nj+yEI+J99u2p7tNWryFUedEmVxjVXnSU3Xp815OfQpNxE
 cWHmki9YTi4/0u1ky76ZStwJI1wU3YCKLCULfVdduLsrDZReF5/e9WrR/uChLuzE
 2LVWEsPRvocOFU3syaGdKIwvoQWKqwPNFbQxhlCflsWnW1YAbAi7eams+fMBBqxg
 A6yxJw7D18ECqDFvN8aH14djuunHA==
X-ME-Sender: <xms:FwDXXZaGEx4VAkFl5kgxTCT4f_DxAJNPXJTMXiDXbrnedxgxF6_qjA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehvddgudehtdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht
 hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:GADXXbbK1e86xE4Jd3bZ-S7Fv-LevNgOXepGo-_iRjzdl8WQBoDB_w>
 <xmx:GADXXQZpsue55AHTIFpbPxuCalR_eTstLUb2g0Izw_2HTu3n7WZS8g>
 <xmx:GADXXYLFJJR7zXIRJZ8XTY44LQWuyGzSdfip4Fs70jpoVFrgyvp7Eg>
 <xmx:GADXXVQGsTHmafYroHYaNB-W6gN85r_StspFnsZ9KDdStxymg2QIJQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 401A2306006C;
 Thu, 21 Nov 2019 16:22:31 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>
Date: Thu, 21 Nov 2019 22:22:29 +0100
Message-ID: <1744280.0WJvlH2Ob5@xps>
In-Reply-To: <CAJFAV8zre=JHGbNASu=QFUHoMTetgNptKG7jbs25HpXPVQkwdQ@mail.gmail.com>
References: <20191121151256.20613-1-david.marchand@redhat.com>
 <CAJFAV8x_djX+-zuNcEg9+J6eT3OdN+fEsqpReut9he2yGMVNmg@mail.gmail.com>
 <CAJFAV8zre=JHGbNASu=QFUHoMTetgNptKG7jbs25HpXPVQkwdQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/11/2019 17:23, David Marchand:
> On Thu, Nov 21, 2019 at 5:17 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> > > > index 90694a3309..217d577018 100644
> > > > --- a/app/test-pmd/testpmd.h
> > > > +++ b/app/test-pmd/testpmd.h
> > > > @@ -58,8 +58,6 @@ typedef uint16_t portid_t;
> > > >  typedef uint16_t queueid_t;
> > > >  typedef uint16_t streamid_t;
> > > >
> > > > -#define MAX_QUEUE_ID ((1 << (sizeof(queueid_t) * 8)) - 1)
> > >
> > > No strong opinion, but would it be simpler if assign 'MAX_QUEUE_ID' to
> > > 'RTE_MAX_QUEUES_PER_PORT' instead?
> > > #define MAX_QUEUE_ID RTE_MAX_QUEUES_PER_PORT
> >
> > This was my first solution once I spotted this.
> > But I prefer to globally replace: when reading this code, using
> > MAX_QUEUE_ID leaves the impression that testpmd has its own
> > restriction on max queue count.
> 
> Btw, not sure we want to backport this, or maybe up to branches
> containing d44f8a485f5d ("app/testpmd: enable per queue configure")
> Opinions?

I am for not backporting.
It is an optimization (stop wasting some memory).