DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jiawei Wang <jiaweiw@nvidia.com>,
	viacheslavo@nvidia.com, Ori Kam <orika@nvidia.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: xiaoyun.li@intel.com, dev@dpdk.org,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide
Date: Thu, 25 Mar 2021 18:15:40 +0100	[thread overview]
Message-ID: <17447772.Sbo81FVF47@thomas> (raw)
In-Reply-To: <05ca2fef-575c-7e95-2033-2a09dcc453c3@intel.com>

25/03/2021 18:10, Ferruh Yigit:
> On 3/9/2021 1:18 PM, Jiawei Wang wrote:
> > Update documentation for sample action usage in testpmd and
> > show the command line example.
> > 
> 
> +1 to document this.
> 
> Indeed for all testpmd flow update, it must be mandatory to update "Flow rules 
> management" section for it, Ori what do you think?
> 
> > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 
> <...>
> 
> > +Sample Sampling/Mirroring rules
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +Sample/Mirroring rules can be set by the following commands
> > +
> > +NIC-RX Sampling rule, the matched ingress packets are duplicated and sent to
> > +the queue 1, and each second packets are marked with 0x1234 and sent to
> > +queue 0.
> > +
> 
> Also each second packets duplicated to queue 1, isn't it, because of 'ratio 2'?
> 
> > +::
> > +
> > + testpmd> set sample_actions 0 mark id  0x1234 / queue index 0 / end
> > + testpmd> flow create 0 ingress group 1 pattern eth / end actions
> > +        sample ratio 2 index 0 / queue index 1 / end
> > +
> > +E-Switch Sampling rule, the matched ingress packets are duplicated and sent
> > +to port id 2, and each second packets are sent to eswitch manager.
> > +
> 
> what is 'E-Switch', or "eswitch manager", isn't the mirror rule generic?

This is the HW switch in Mellanox devices.
It should not be mentioned in this generic doc.



  reply	other threads:[~2021-03-25 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 13:18 Jiawei Wang
2021-03-25 17:10 ` Ferruh Yigit
2021-03-25 17:15   ` Thomas Monjalon [this message]
2021-03-31  6:58     ` Jiawei(Jonny) Wang
2021-03-31  6:38   ` Jiawei(Jonny) Wang
2021-03-31  9:44     ` Ferruh Yigit
2021-03-31 14:38       ` Jiawei(Jonny) Wang
2021-03-31 15:26         ` Ferruh Yigit
2021-03-31  8:51 ` [dpdk-dev] [PATCH v2] " Jiawei Wang
2021-04-01  2:39 ` [dpdk-dev] [PATCH v3] " Jiawei Wang
2021-04-01 11:52   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17447772.Sbo81FVF47@thomas \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jiaweiw@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).