From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D561A0A02; Thu, 25 Mar 2021 18:15:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DA48140EF8; Thu, 25 Mar 2021 18:15:45 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 905AB140EE4 for ; Thu, 25 Mar 2021 18:15:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3F9E85C012A; Thu, 25 Mar 2021 13:15:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 25 Mar 2021 13:15:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= iWljrVFN4IOVRgISEVLm8S2YGbC7ooCv9uK9rgNA4kc=; b=2Sz+loAnN0HqHY21 vyqjG136jW+qIXYICWjUfsUQfV7BOCzy/sOzSUHWzAJmvKKtWbYHOjz5RZRoIy6Z u/I06aFrH5SGWeD6rGdeQLG4AtwdMRqmJFl9MeSozsr8TWb/ncc/bz1g591wGQCc wDjWhCBrHH2HPXuuzQAzcPIgEzxu7DnilLYl4nejwXMKjQbQS5T5J/yI8LOrdZHw ThlCMvAjtx8Hl7wk5/Ij/KNJhJA+X/2OOQSbpYGATrWucXcrwVtckZFGeVbC2Sw8 lHGT+/oVx7G4CZOTHJJA8LxSMmiAxFML5bCVnk05BEGhls3MPf9QC6tKlWPoEXk8 OAPNmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=iWljrVFN4IOVRgISEVLm8S2YGbC7ooCv9uK9rgNA4 kc=; b=tfvHu+GEk3YY/9/WmP5EhX7EpbkNlhec5A3n/NuA7wWsGbxIcW1AV32IR nVNXI6PbYXSswnVV3gfAVOsoBEKhHyi8jPlo6vc2s1GXycXEmNX8i9F/DB5rPFeo k1Tf3Ze0rl0wHByZdZ2JHMjoMQ5ouopxz7qk4yellOd3V4PAraxDDSsDVf1go915 sbVUPXccybIpbwfD8qJcx6awLWMdJEQLP21eawLcDkg5YbaLqeXhT3N1OOTTeGN3 YsT2U0QJP7r20af3FMnHzqKY+LeiWaoAF/ul1U3OyJNYi/IWoAXyitMMTAUhLXHs Y+y05Y3JoIkG4XKuMBj+AzuH4VBrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehtddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D83F324005C; Thu, 25 Mar 2021 13:15:41 -0400 (EDT) From: Thomas Monjalon To: Jiawei Wang , viacheslavo@nvidia.com, Ori Kam , Ferruh Yigit Cc: xiaoyun.li@intel.com, dev@dpdk.org, Andrew Rybchenko Date: Thu, 25 Mar 2021 18:15:40 +0100 Message-ID: <17447772.Sbo81FVF47@thomas> In-Reply-To: <05ca2fef-575c-7e95-2033-2a09dcc453c3@intel.com> References: <1615295935-11197-1-git-send-email-jiaweiw@nvidia.com> <05ca2fef-575c-7e95-2033-2a09dcc453c3@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/03/2021 18:10, Ferruh Yigit: > On 3/9/2021 1:18 PM, Jiawei Wang wrote: > > Update documentation for sample action usage in testpmd and > > show the command line example. > > > > +1 to document this. > > Indeed for all testpmd flow update, it must be mandatory to update "Flow rules > management" section for it, Ori what do you think? > > > Signed-off-by: Jiawei Wang > > Acked-by: Viacheslav Ovsiienko > > <...> > > > +Sample Sampling/Mirroring rules > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Sample/Mirroring rules can be set by the following commands > > + > > +NIC-RX Sampling rule, the matched ingress packets are duplicated and sent to > > +the queue 1, and each second packets are marked with 0x1234 and sent to > > +queue 0. > > + > > Also each second packets duplicated to queue 1, isn't it, because of 'ratio 2'? > > > +:: > > + > > + testpmd> set sample_actions 0 mark id 0x1234 / queue index 0 / end > > + testpmd> flow create 0 ingress group 1 pattern eth / end actions > > + sample ratio 2 index 0 / queue index 1 / end > > + > > +E-Switch Sampling rule, the matched ingress packets are duplicated and sent > > +to port id 2, and each second packets are sent to eswitch manager. > > + > > what is 'E-Switch', or "eswitch manager", isn't the mirror rule generic? This is the HW switch in Mellanox devices. It should not be mentioned in this generic doc.