From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F2721324C; Mon, 31 Jul 2017 09:46:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 62B8220975; Mon, 31 Jul 2017 03:46:40 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 31 Jul 2017 03:46:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=XsZGvQo2nUkLI7F sFo1zLnuTh/2DfrSRkEhWzTkBC04=; b=ZD2E4wZY1IQErWlkNmhx+AISOVg0aHL rg7n4/s21Qc3DSosCUv99bCt3CEsLyV395PHdRj/OJMkOKXtZjy1UZ8/u/KSBtcy cClkpq2tYgCwoHG4VcqOvWG0FkVW6m5VR598cvqfvYyy09AsiHClSYjYm7J6iRRt AvaJDqTCCCKY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=XsZGvQo2nUkLI7FsFo1zLnuTh/2DfrSRkEhWzTkBC04=; b=EEfHMrzM H9QgKWhECl4GzqcSicwfHGNiUM0fp9wjx1j/0MeIFz7m11bpOSqKkLPjSqMpSn3H vDSFepQ2uWGI7gY3aHV4fHslw8SCsbbblhLrisqTWbUe2NcMTUonR8bReFHHjEm6 TP2QHDBCoP7fnkkG/qGUjALpO/sSJnmFv1Zy8VWmeuhclzcgpO5Miu59jLgSpxiS 94UVYwXt32WXq0aqGrxHxM3aAVjR0MsxrAHZqqMoWepZ8yQrInLP1oxT29VMsAZN DW5uLfFpM/shaoXiUHU5CPuKJpEvQtTuzmK5EGmGIAHZKJHJ9lr2up8OTKhraTVl KJA7WIcXdmtFtQ== X-ME-Sender: X-Sasl-enc: 6T6WSmbSq7ErClac0QpeUnDGwjywSaZrJXBgZcxfqoEO 1501487200 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 109E67E4EA; Mon, 31 Jul 2017 03:46:40 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: stable@dpdk.org, dev@dpdk.org, Jan Blunck Date: Mon, 31 Jul 2017 09:46:39 +0200 Message-ID: <1745224.TJoYg1OxSO@xps> In-Reply-To: <3505500ec4b4a452528da1eb2076e11bdc22068c.1501069907.git.gaetan.rivet@6wind.com> References: <3505500ec4b4a452528da1eb2076e11bdc22068c.1501069907.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] dev: fix dev_attach proceeding with vdev on success X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 07:46:41 -0000 26/07/2017 13:52, Gaetan Rivet: > When rte_eal_hotplug_add() successfully probe a device, the return value > is zero. The check afterward only returns on error different from > -EINVAL. It should return also on success, as there is no need to > attempt probing the device with vdev. > > Fixes: 0bba9e605048 ("eal: use new hotplug API in attach") > Cc: stable@dpdk.org > Cc: Jan Blunck > > Signed-off-by: Gaetan Rivet Applied, thanks