From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 6CAFF5A44 for ; Thu, 5 Jan 2017 16:12:28 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id c85so249753171wmi.1 for ; Thu, 05 Jan 2017 07:12:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=xno/JrRmqISKbNNKJb+PUcv+r1N5Sc34h+w0mXt7kuE=; b=12gfPB2oe90KfTy9x/aYe5l8TUTubsPLg8kZhr82XsjPpic00YZxtZEBjwhkxczoPj VTC6yp0QMt/OJm283qoB6i3EWIdhjDml3MDdroAi90GLcJC6dyQeZ7GPglLK19D+aQDl tapk6Io4t20QtPEMnQdPDLLrYTNmNKb4S0AOH2RKiLXZieMW/lqagUJgBkSfwkhq8xbF HUEmeseZ+HDGVcaFAsMd149jfOgpCztVvR7lIR8eiXmvrOZPTmknj8sPiT0NV7DBvcrG eZVj8MomZ2FIDKxVk2rwKn6US/r9BTkjwPA3JLISizWDPbZNLNfpcHptCPI2hlSTyiIx /iRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=xno/JrRmqISKbNNKJb+PUcv+r1N5Sc34h+w0mXt7kuE=; b=Gb4TVoLTUaU0Bjsw4EPJWMzZDGGjDYYxsORKwndCj7YwU+BoNjnjvczFfwNNT2+Zxm WBrSoR8ajMjstl+78tWLdHjeCRGn16Uqni85nXQDpYVu0YyDoLS5+nmEyeQkYLQFkNDw 5xNeb0JGjk5e9PGd09KIldewujOkwbwvZjdNFD8V+JlRZdY1Dyy9mJsdHgliEaYWaJQe rLJMrcYhlnVM9X4nmt9spl6hcQTj8w/TRYVBPMIRQMg+Ko/sUWOvWseYVPi+9SAoR6I1 7b8uzW9r5IbXOScuDO0GoZWeS+itWTTZyBQfADSOpC5BWf3PwLJBGzHztKpL5AqiFPdF tfeA== X-Gm-Message-State: AIkVDXI3c98CYsOiKfrcW6W+soqf5mK42BQ6vDEMsph2T2H5pUMavRa7H2eg77gvXHHjJyOH X-Received: by 10.28.191.219 with SMTP id o88mr57958023wmi.30.1483629148075; Thu, 05 Jan 2017 07:12:28 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id di9sm104187166wjc.37.2017.01.05.07.12.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 07:12:27 -0800 (PST) From: Thomas Monjalon To: Piotr Azarewicz Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com Date: Thu, 05 Jan 2017 16:12:26 +0100 Message-ID: <17462396.FW1IWXuNnf@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1483624286-92526-1-git-send-email-piotrx.t.azarewicz@intel.com> References: <1483448523-150510-1-git-send-email-piotrx.t.azarewicz@intel.com> <1483624286-92526-1-git-send-email-piotrx.t.azarewicz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] crypto/aesni_gcm: migration from MB library to ISA-L X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 15:12:28 -0000 2017-01-05 14:51, Piotr Azarewicz: > Current Cryptodev AES-NI GCM PMD is implemented using Multi Buffer > Crypto library.This patch reimplement the device using ISA-L Crypto > library: https://github.com/01org/isa-l_crypto. > > The migration entailed the following additional support for: > * GMAC algorithm. > * 256-bit cipher key. > * Session-less mode. > * Out-of place processing > * Scatter-gatter support for chained mbufs (only out-of place and > destination mbuf must be contiguous) > > Verified current unit tests and added new unit tests to verify new > functionalities. > > PERFORMANCE COMPARISON > ---------------------- > Comparison the new and old implementation is made by running app/test > and calling cryptodev_aesni_gcm_perftest. > As we may see below, the new implementation has small performance drop > when buffer size is above 64B. I am a bit surprised that you change for lower performance. I understand that it brings new features. Is it possible to add such features without performance impact? > Old implementation with MB library: > Cipher algo: AES_GCM Cipher hash: AES_GCM ciphr key: 128b burst size: 32 > Buffer Size(B) OPS(M) Throughput(Gbps) Retries EmptyPolls > 64 4.57 2.34 0 0 > 128 4.28 4.39 0 0 > 256 2.76 5.66 0 0 > 512 1.60 6.56 0 0 > 1024 0.90 7.34 0 0 > 1536 0.62 7.66 0 0 > 2048 0.48 7.84 0 0 > > New implementation with ISA-L library: > Cipher algo: AES_GCM Cipher hash: AES_GCM ciphr key: 128b burst size: 32 > Buffer Size(B) OPS(M) Throughput(Gbps) Retries EmptyPolls > 64 4.62 2.37 0 0 > 128 4.06 4.16 0 0 > 256 2.65 5.44 0 0 > 512 1.57 6.45 0 0 > 1024 0.89 7.26 0 0 > 1536 0.62 7.58 0 0 > 2048 0.47 7.77 0 0 >