From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED362466CD; Mon, 5 May 2025 17:04:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF6D44025D; Mon, 5 May 2025 17:04:58 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 568374003C for ; Mon, 5 May 2025 17:04:57 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1213) id 81F232115DB4; Mon, 5 May 2025 08:04:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 81F232115DB4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1746457496; bh=ZLHm+8z8u2EjACow6z+iGCuIZQVnekO61CCCZz3ljgg=; h=From:To:Cc:Subject:Date:From; b=SJGERmzs9xBH81BfuTfKa2w3v7wP1iDOafTC6A1jaPYG4CmbLa1yU2g/fRAPVm2Tg z5zM3trayF2L68NAGTc4SfqmCYHjS2+Iyq4mbBAR2DW67Zwivw9QQIxk+RmhvXsoxI bqafQXWTMst3Nd349h6AWqNj30mSh9HUk6fWhqwc= From: Andre Muezerie To: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad Cc: dev@dpdk.org, Andre Muezerie Subject: [PATCH] net/mlx5: use portable version of __builtin_ffsl Date: Mon, 5 May 2025 08:04:52 -0700 Message-Id: <1746457492-10012-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Builtin __builtin_ffsl is not available with MSVC therefore a portable replacement should be used. Function rte_ffs32 is already available in eal and should be used instead. Signed-off-by: Andre Muezerie --- drivers/net/mlx5/mlx5_tx.c | 4 ++-- drivers/net/mlx5/mlx5_utils.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c index 39afca3d64..b2522e7170 100644 --- a/drivers/net/mlx5/mlx5_tx.c +++ b/drivers/net/mlx5/mlx5_tx.c @@ -629,8 +629,8 @@ mlx5_select_tx_function(struct rte_eth_dev *dev) } if (tmp == diff) { tmp = txoff_func[i].olx ^ txoff_func[m].olx; - if (__builtin_ffsl(txoff_func[i].olx & ~tmp) < - __builtin_ffsl(txoff_func[m].olx & ~tmp)) { + if (rte_ffs32(txoff_func[i].olx & ~tmp) < + rte_ffs32(txoff_func[m].olx & ~tmp)) { /* Lighter not requested offload. */ m = i; } diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index d882af6047..645bb118fb 100644 --- a/drivers/net/mlx5/mlx5_utils.c +++ b/drivers/net/mlx5/mlx5_utils.c @@ -84,7 +84,7 @@ mlx5_ipool_create(struct mlx5_indexed_pool_config *cfg) if (!cfg || (!cfg->malloc ^ !cfg->free) || (cfg->per_core_cache && cfg->release_mem_en) || (cfg->trunk_size && ((cfg->trunk_size & (cfg->trunk_size - 1)) || - ((__builtin_ffs(cfg->trunk_size) + TRUNK_IDX_BITS) > 32)))) + ((rte_ffs32(cfg->trunk_size) + TRUNK_IDX_BITS) > 32)))) return NULL; pool = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*pool) + cfg->grow_trunk * sizeof(pool->grow_tbl[0]), RTE_CACHE_LINE_SIZE, -- 2.49.0.vfs.0.2