From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2D72B49DF; Thu, 9 May 2019 22:24:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C37C6239B8; Thu, 9 May 2019 16:24:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 16:24:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=xxbQhKrM7y8CW5NKLLZO2M8bZiXnf+SGB/g5vSVEKno=; b=JEM9q+EeTOZX nCeb/UIIlMcEytFKZNSI1H0c4RPnmPXGcaHuZUGZtrBLUVIsawJyHr7huRxNr81L LFBbFpBB7MOWmkQiBBy0V0AuuQdkwvPacSve9Xy0GHWZyKvUf3+Y/9pM06Fgoo0O 91wn1tzhTBu/qX83siA/1lneLFfqp0A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xxbQhKrM7y8CW5NKLLZO2M8bZiXnf+SGB/g5vSVEK no=; b=u2rDZ7aEJEX5eHIvwPyn9jHm5oc34+WDwK6htk18AqHZPv9qiXmTIAVHp Uz8FvK4BWDUROihBLs+MgAB7D3fX1fb3KARYBY3EPFKJtGQQ32iy1EAJtULVrdst otUJm4JOWeSEJjtHFJJhOcvNOo4Pa6KGAEZ3E9ucBlxUQLLOXRH1kSozxYXcEu6B huB5ui/ClTwBY7vLz76Z9AdeqmpU7PU1OzJ6qxke6C/pX7eU1lczjIk9AtrC7nm8 yCvFLqTCjXY2CnzCj5R8DTOdEvNkrbJmGPhJ4jzxszr9It9l+ypnyB1GTIxEBDt7 rCf9aPFciwNkVVhQguxf9YOIB7PCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6453F80063; Thu, 9 May 2019 16:24:00 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: stable@dpdk.org, "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "dev@dpdk.org" , Honnappa Nagarahalli , "zhongdahulinfan@163.com" , nd Date: Thu, 09 May 2019 22:23:59 +0200 Message-ID: <1747192.QZgYevTSIy@xps> In-Reply-To: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 20:24:03 -0000 09/05/2019 22:14, Dharmik Thakkar: > > On May 9, 2019, at 2:27 PM, Wang, Yipeng1 wrote: > >> - RETURN_IF_TRUE(((h == NULL) || (position == EMPTY_SLOT)), -EINVAL); > >> + /* Key index where key is stored, adding the first dummy index*/ > > [Wang, Yipeng] Minor issue, missing a space at the end. > Is there a need to update the version? No, I am applying. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 81C53A0096 for ; Thu, 9 May 2019 22:24:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20EF74CA6; Thu, 9 May 2019 22:24:05 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2D72B49DF; Thu, 9 May 2019 22:24:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C37C6239B8; Thu, 9 May 2019 16:24:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 16:24:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=xxbQhKrM7y8CW5NKLLZO2M8bZiXnf+SGB/g5vSVEKno=; b=JEM9q+EeTOZX nCeb/UIIlMcEytFKZNSI1H0c4RPnmPXGcaHuZUGZtrBLUVIsawJyHr7huRxNr81L LFBbFpBB7MOWmkQiBBy0V0AuuQdkwvPacSve9Xy0GHWZyKvUf3+Y/9pM06Fgoo0O 91wn1tzhTBu/qX83siA/1lneLFfqp0A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xxbQhKrM7y8CW5NKLLZO2M8bZiXnf+SGB/g5vSVEK no=; b=u2rDZ7aEJEX5eHIvwPyn9jHm5oc34+WDwK6htk18AqHZPv9qiXmTIAVHp Uz8FvK4BWDUROihBLs+MgAB7D3fX1fb3KARYBY3EPFKJtGQQ32iy1EAJtULVrdst otUJm4JOWeSEJjtHFJJhOcvNOo4Pa6KGAEZ3E9ucBlxUQLLOXRH1kSozxYXcEu6B huB5ui/ClTwBY7vLz76Z9AdeqmpU7PU1OzJ6qxke6C/pX7eU1lczjIk9AtrC7nm8 yCvFLqTCjXY2CnzCj5R8DTOdEvNkrbJmGPhJ4jzxszr9It9l+ypnyB1GTIxEBDt7 rCf9aPFciwNkVVhQguxf9YOIB7PCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6453F80063; Thu, 9 May 2019 16:24:00 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: stable@dpdk.org, "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "dev@dpdk.org" , Honnappa Nagarahalli , "zhongdahulinfan@163.com" , nd Date: Thu, 09 May 2019 22:23:59 +0200 Message-ID: <1747192.QZgYevTSIy@xps> In-Reply-To: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509202359.n28WtH_dzTMv3s91NflsTsprrXL9asMlxOB0cS2-lB8@z> 09/05/2019 22:14, Dharmik Thakkar: > > On May 9, 2019, at 2:27 PM, Wang, Yipeng1 wrote: > >> - RETURN_IF_TRUE(((h == NULL) || (position == EMPTY_SLOT)), -EINVAL); > >> + /* Key index where key is stored, adding the first dummy index*/ > > [Wang, Yipeng] Minor issue, missing a space at the end. > Is there a need to update the version? No, I am applying.