* [dpdk-dev] [PATCH] lib/gro: fix bitwise overflow issue
@ 2017-07-31 1:43 Jiayu Hu
2017-07-31 7:01 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Jiayu Hu @ 2017-07-31 1:43 UTC (permalink / raw)
To: dev; +Cc: thomas, jianfeng.tan, Jiayu Hu
When try to get GRO types, expression "1 << i" with type "int" may
overflow. This patch is to fix this issue.
Fixes: e996506a1c07 ("lib/gro: add Generic Receive Offload API framework")
Coverity issue: 158664
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
lib/librte_gro/rte_gro.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_gro/rte_gro.c b/lib/librte_gro/rte_gro.c
index 4998b90..7853246 100644
--- a/lib/librte_gro/rte_gro.c
+++ b/lib/librte_gro/rte_gro.c
@@ -81,7 +81,7 @@ rte_gro_ctx_create(const struct rte_gro_param *param)
return NULL;
for (i = 0; i < RTE_GRO_TYPE_MAX_NUM; i++) {
- gro_type_flag = 1 << i;
+ gro_type_flag = 1ULL << i;
if ((param->gro_types & gro_type_flag) == 0)
continue;
@@ -116,7 +116,7 @@ rte_gro_ctx_destroy(void *ctx)
if (gro_ctx == NULL)
return;
for (i = 0; i < RTE_GRO_TYPE_MAX_NUM; i++) {
- gro_type_flag = 1 << i;
+ gro_type_flag = 1ULL << i;
if ((gro_ctx->gro_types & gro_type_flag) == 0)
continue;
destroy_tbl_fn = tbl_destroy_fn[i];
@@ -265,7 +265,7 @@ rte_gro_get_pkt_count(void *ctx)
uint8_t i;
for (i = 0; i < RTE_GRO_TYPE_MAX_NUM; i++) {
- gro_type_flag = 1 << i;
+ gro_type_flag = 1ULL << i;
if ((gro_ctx->gro_types & gro_type_flag) == 0)
continue;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/gro: fix bitwise overflow issue
2017-07-31 1:43 [dpdk-dev] [PATCH] lib/gro: fix bitwise overflow issue Jiayu Hu
@ 2017-07-31 7:01 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-07-31 7:01 UTC (permalink / raw)
To: Jiayu Hu; +Cc: dev, jianfeng.tan
31/07/2017 03:43, Jiayu Hu:
> When try to get GRO types, expression "1 << i" with type "int" may
> overflow. This patch is to fix this issue.
>
> Fixes: e996506a1c07 ("lib/gro: add Generic Receive Offload API framework")
> Coverity issue: 158664
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 1:43 [dpdk-dev] [PATCH] lib/gro: fix bitwise overflow issue Jiayu Hu
2017-07-31 7:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).