From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 9D58712A8 for ; Tue, 31 Jan 2017 15:10:24 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id v77so95080366wmv.0 for ; Tue, 31 Jan 2017 06:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=KtxUQ81IuevAi9XrkrIiVaaBEIuhfaR+RdWxp/LgOls=; b=zNlkRpUgvMFhEJq06pEXogyWV1a4md/gei7/g9AB9tqLWxiDGMo5NauHQyFz8QUjVC PLMhN3uH8EP/CKHPnDINns6DHo/Z3crYJ5QnGaUz18crTPEq24pQGVXWNPzen5/uWISr V1fVxE4xSZ9S9i7CaBEL9yByJ0mdXTjHW42eZ/fmrfNx4Iuyaa4r+jQO+cIpSbTm3Jgc W0kRTjIKMomRjv0ewXrOG8TL+H8TwCqswrCS3wF7HO1teQfJHXKvBEfbd41j0STNFYJE yt6Gl+BVEE9Q//dfZRROUoViVQtLN0BFK6XsnHnDqRP0/7QdFkLTRlrzGt8VC9prlWrD EaWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=KtxUQ81IuevAi9XrkrIiVaaBEIuhfaR+RdWxp/LgOls=; b=nlNp2OJ6NT4hoRezTg1uPZJK5xAfZmJRltnXx0k85ONoqOO98c8QGxK2hSunhoojco LSrprY8sK9/FMR8+Mt2eLT2JrSYsIcXNI2MNj1pPZ58smU4rukPWjbGP8fAhyZj0AfIm yVcy7nqH1ZavxHhla4auEdyns/cQeEe6dvOR6hZvFLz0z8dGeAOUGLsRqfJE0qE3DVbb b+zkn/OiZS/KxPRdWKUNEHdkWxSUqViRyeDJ7uEAEzt3OiSDj4ugbf4n7yNk7L0au4Lu nK4JTpNFdL8vNfz2tTJeSVf/3kfkla64mVEbpIrlKEVOlCclIyibb2OUq40Io1e/JvJx RRsw== X-Gm-Message-State: AIkVDXLqAx+mlyeMUI8T8XYXmLkKrrn7WPXBWQNXt1WL3JgC2cn/9gFpaaSbskZG/T1dvNTr X-Received: by 10.28.111.155 with SMTP id c27mr18005672wmi.18.1485871824321; Tue, 31 Jan 2017 06:10:24 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q1sm24186221wmd.6.2017.01.31.06.10.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jan 2017 06:10:23 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit , Pablo de Lara , Fan Zhang Cc: dev@dpdk.org Date: Tue, 31 Jan 2017 15:10:22 +0100 Message-ID: <1747389.KZLHpWvR9T@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170131115950.25660-2-ferruh.yigit@intel.com> References: <20170131115950.25660-1-ferruh.yigit@intel.com> <20170131115950.25660-2-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] mk: move crypto scheduler library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2017 14:10:24 -0000 2017-01-31 11:59, Ferruh Yigit: > There is already a block for crypto libraries, move the PMD library to > that block. > > This prevents extra ifdef check for cryptodev. That's why I thought also when reading this patch: http://dpdk.org/commit/dbb336407 Then I've read its message: "Different than other cryptodev PMDs, scheduler PMD is required to be built as shared libraries." I guess the explanation is that it has an API (like bonding has): drivers/crypto/scheduler/rte_cryptodev_scheduler.h However, it is neither referenced in doc/api/doxy-api.conf nor doc/api/doxy-api-index.md. > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -103,10 +103,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER) += -lrte_reorder > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt -lxenstore > > -ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += -lrte_pmd_crypto_scheduler > -endif > - > ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > # plugins (link only if static libraries) > > @@ -153,6 +149,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ZUC) += -lrte_pmd_zuc > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ZUC) += -L$(LIBSSO_ZUC_PATH)/build -lsso_zuc > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += -lrte_pmd_armv8 > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += -L$(ARMV8_CRYPTO_LIB_PATH) -larmv8_crypto > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += -lrte_pmd_crypto_scheduler > endif # CONFIG_RTE_LIBRTE_CRYPTODEV > > endif # !CONFIG_RTE_BUILD_SHARED_LIBS I must say the quick overview I had on this PMD is not very promising. Please Pablo and Fan, try to better explain things in the patches and get more review on framework integration.