From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CF754FEB for ; Fri, 26 Oct 2018 15:28:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6F08421E8D; Fri, 26 Oct 2018 09:28:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Oct 2018 09:28:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XFD5eS2lBogj7Hy56N41YmhfLE8Be9iizd9OOYCYsUo=; b=B06210hH5Ma5 ZOO7oTgxnfDJAC21vrm8yvzOPy1lolUzlGP7sv9VeYQlbicwWA4TGarWroBEInah 6Mq9H5aWC3AouLixmf+DNrPGGCCJZAcjaVQ7dhNl9UAbhgTfBYFwmSB+ZJkCYKQM NKrUl+9aUyzLm0fmgYmGBLVXFPp2fTU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XFD5eS2lBogj7Hy56N41YmhfLE8Be9iizd9OOYCYs Uo=; b=anOTmj/K0Bw4DSjpMIFMgY+mLLF2UmyAetZJj8YgFfwxJKB7gms/0/bpB Y0qVadpaRhccEcjKnvG4YiJkZd1aTpjk7tTaSbIY+Y40z8SVfkwRl0aYLscBZbd9 BXbZvOAFrWZOSSdci/lA20jKKg4W8ryqVnhK/spxvhtykLokOMV2u4ktrD8cRn1F h6pfcKmnuGyAwKjKqLF5M9dxAtTvaU4PwTfVGIT28z5XfB+bN30S98DS5Xpb606X bPEpvskjXeASSlSL6WO1sdQol6p2lZMgQgjHLSfzWny72spqa8PgHBpzzXGxTomk 805rr7A26MkFI8Q+WndFld/e7Kdiw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B0A9102F2; Fri, 26 Oct 2018 09:28:55 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, stephen@networkplumber.org Date: Fri, 26 Oct 2018 15:29:00 +0200 Message-ID: <1748383.aenPN5C8uf@xps> In-Reply-To: <20181024111010.15568-1-ferruh.yigit@intel.com> References: <20181024105443.57063-1-ferruh.yigit@intel.com> <20181024111010.15568-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build for Linux kernel 4.19 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 13:28:58 -0000 24/10/2018 13:10, Ferruh Yigit: > The build error observed with Linux kernel 4.19 when KNI ethtool > support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=3Dy) >=20 > .../build/build/kernel/linux/kni/kni_ethtool.c:193:3: > error: =E2=80=98struct ethtool_ops=E2=80=99 has no member named =E2=80= =98get_settings=E2=80=99; > .get_settings =3D kni_get_settings, > ^~~~~~~~~~~~ >=20 > .../build/build/kernel/linux/kni/kni_ethtool.c:194:3: > error: =E2=80=98struct ethtool_ops=E2=80=99 has no member named =E2=80= =98set_settings=E2=80=99; > .set_settings =3D kni_set_settings, > ^~~~~~~~~~~~ >=20 > With kernel 4.19 ethtool_ops `get_settings` & `set_settings` are > replaced with `get_link_ksettings` & `set_link_ksettings` > Commit 9b3004953503 ("ethtool: drop get_settings and set_settings callbac= ks") >=20 > This fix practically removes `get_settings` & `set_settings` support > for the kernel versions that have the new ethtool_ops without > implementing the new ones. >=20 > Signed-off-by: Ferruh Yigit Applied, thanks