* [PATCH] common/mlx5: avoid warning about operation mixing different enum types
@ 2025-05-27 23:41 Andre Muezerie
0 siblings, 0 replies; only message in thread
From: Andre Muezerie @ 2025-05-27 23:41 UTC (permalink / raw)
To: Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam,
Suanming Mou, Matan Azrad
Cc: dev, Andre Muezerie
When compiling with MSVC, warnings like the one below pop up:
../drivers/common/mlx5/mlx5_devx_cmds.c(554): warning C5287: operands
are different enum types
'<unnamed-enum-MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE>' and
'<unnamed-enum-MLX5_HCA_CAP_OPMOD_GET_MAX>'; use an explicit cast
to silence this warning
The values in both enums indicate that this sort of mixed bit
manipulation is intentional, so this patch just uses an explicit
cast to avoid the warning.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
drivers/common/mlx5/mlx5_devx_cmds.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 39a4298b58..1a3f4580d8 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -552,7 +552,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, NULL,
MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities");
vdpa_attr->valid = 0;
@@ -851,7 +851,7 @@ mlx5_devx_cmd_query_hca_parse_graph_node_cap
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_PARSE_GRAPH_NODE_CAP |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr)
return rc;
attr->node_in = MLX5_GET(parse_graph_node_cap, hcattr, node_in);
@@ -884,7 +884,7 @@ mlx5_devx_cmd_query_hca_parse_graph_node_cap
/* Get the max supported samples from HCA CAP 2 */
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE_2 |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr)
return rc;
attr->max_num_prog_sample =
@@ -943,7 +943,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr)
return rc;
hca_cap_2_sup = MLX5_GET(cmd_hca_cap, hcattr, hca_cap_2);
@@ -1127,7 +1127,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
MLX5_GET(cmd_hca_cap, hcattr, aes_xts_single_block_le_tweak);
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_CRYPTO |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr)
return -1;
attr->crypto_wrapped_import_method = !!(MLX5_GET(crypto_caps,
@@ -1152,7 +1152,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
if (hca_cap_2_sup) {
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE_2 |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
DRV_LOG(DEBUG,
"Failed to query DevX HCA capabilities 2.");
@@ -1193,7 +1193,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
if (attr->qos.sup) {
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_QOS_CAP |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
DRV_LOG(DEBUG, "Failed to query devx QOS capabilities");
return rc;
@@ -1229,7 +1229,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
/* Query Flow Sampler Capability From FLow Table Properties Layout. */
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_NIC_FLOW_TABLE |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
attr->log_max_ft_sampler_num = 0;
return rc;
@@ -1286,7 +1286,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
/* Query HCA offloads for Ethernet protocol. */
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_ETHERNET_OFFLOAD_CAPS |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
attr->eth_net_offloads = 0;
return rc;
@@ -1355,7 +1355,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
if (attr->wqe_based_flow_table_sup) {
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_WQE_BASED_FLOW_TABLE |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
DRV_LOG(DEBUG, "Failed to query WQE Based Flow table capabilities");
return rc;
@@ -1378,7 +1378,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
if (attr->roce) {
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_ROCE |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr) {
DRV_LOG(DEBUG,
"Failed to query devx HCA ROCE capabilities");
@@ -1396,7 +1396,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
if (attr->eswitch_manager) {
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_SET_HCA_CAP_OP_MOD_ESW |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr)
return rc;
attr->esw_mgr_vport_id_valid =
@@ -1410,7 +1410,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
hcattr = mlx5_devx_get_hca_cap(ctx, in, out, &rc,
MLX5_GET_HCA_CAP_OP_MOD_ESW_FLOW_TABLE |
- MLX5_HCA_CAP_OPMOD_GET_CUR);
+ (uint32_t)MLX5_HCA_CAP_OPMOD_GET_CUR);
if (!hcattr)
return rc;
esw_reg = MLX5_GET(flow_table_esw_cap, hcattr,
--
2.49.0.vfs.0.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-05-27 23:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-27 23:41 [PATCH] common/mlx5: avoid warning about operation mixing different enum types Andre Muezerie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).