From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4E43E98
 for <dev@dpdk.org>; Tue, 31 Jul 2018 17:05:58 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E592121F86;
 Tue, 31 Jul 2018 11:05:57 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 31 Jul 2018 11:05:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=uFM9Nw/CFg3uxmR01WdXyU/9qp
 O5/N9NxB14UJRzI3Y=; b=F2qCG2gvB1c+54p7ht0aQdMqk0u85JLfZ+NHaJzNbK
 IO7dW0VGc2QPm9jQyplwGq14Hzfr/Zb1hmJ10UQugfFSoU0XCNM+3zE51DqTH95Q
 9S6luL/ZoNm4+5RsIASNcijhdoUe+FP0/mZKW/u0MigiRPmIPHNmP4t0fj0YGCuP
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uFM9Nw
 /CFg3uxmR01WdXyU/9qpO5/N9NxB14UJRzI3Y=; b=ixp9PxLZBvKGHei8QW9PZM
 hF9DOq6W+MLFIZW6tqoHyD/GBnQ+LZqkm48c74fBORrtdRLOyOXIfEguP7byJNVP
 RI4BPYJhPcAnyfQFjtZQNz0TqeQkmWhEBBZJLrb3Icr64ykj6S7y7VoVS6K/6Khn
 yo9NmtdCGnohF0cv8eLi+zf17A6u2oljZjCARNMcOOq2XeBNmlyjuHMFn1xvyxNU
 JCNCMH74XwwpnYALvVacoY4CCL5veH71Bu9OJJR3wY7fPxyG3XqpNSvF+BC9G2vj
 biA1e7TwJr6hkRaF8Rm5XVtb8wNQQCws+zo3mSuiE2mGMCpjuqeUSRFTiuufMtAA
 ==
X-ME-Proxy: <xmx:1XpgWz8RHZfchgsotNYON4Ed8tKpQsYPtRtFB_mQTNrzB4pNcLr8tg>
 <xmx:1XpgW2oGk6OeNI79vEXJtbsw3_cfi7w0jAHvUzTy2J47QrG02J1onQ>
 <xmx:1XpgW2piNw_lWmoHqDzQxSSJkhx-hvAcH--LPjii-8mhltCd6zQkGg>
 <xmx:1XpgW0mkLUspqPzfWNH4sHGDJv5IzHanX26n9Mb4WaHFIENrISL3Bg>
 <xmx:1XpgW4F-eWbGcPLu5vcX6AUO8mTJDlNMjfGUU4zMD2Nk4me-aVxRog>
 <xmx:1XpgW6t8d7vTp3iur_PT56duDN74Qhabgj-iDWHStl9BQVSHmgeIyg>
X-ME-Sender: <xms:1XpgW8vEeFPNS0123GvCDydF5_YLYo6Ti3bEl1_K2kVLmqyWVCpIKw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 0FC7F10261;
 Tue, 31 Jul 2018 11:05:56 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, Ben Shelton <benjamin.h.shelton@intel.com>
Date: Tue, 31 Jul 2018 17:05:52 +0200
Message-ID: <1748890.xKDDESA46q@xps>
In-Reply-To: <20180710153301.546-1-benjamin.h.shelton@intel.com>
References: <20180710153301.546-1-benjamin.h.shelton@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent
	update API function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 15:05:58 -0000

Cristian, review please?

10/07/2018 17:33, Ben Shelton:
> The node parent update API function may be used to update the
> priority/weight of an existing node.  Update the documentation to
> indicate that this use case is supported.
> 
> Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
[...]
>  /**
>   * Traffic manager node parent update
>   *
> + * This function may be used to move a node and its children to a different
> + * parent.  Additionally, if the new parent is the same as the current parent,
> + * this function will update the priority/weight of an existing node.
> + *
>   * Restriction for root node: its parent cannot be changed.
>   *
>   * This function can only be called after the rte_tm_hierarchy_commit()