* [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function
@ 2018-07-10 15:33 Ben Shelton
2018-07-31 15:05 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ben Shelton @ 2018-07-10 15:33 UTC (permalink / raw)
To: Cristian Dumitrescu, Thomas Monjalon; +Cc: dev, Ben Shelton
The node parent update API function may be used to update the
priority/weight of an existing node. Update the documentation to
indicate that this use case is supported.
Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
---
lib/librte_ethdev/rte_tm.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
index 7255403..955f02f 100644
--- a/lib/librte_ethdev/rte_tm.h
+++ b/lib/librte_ethdev/rte_tm.h
@@ -1569,6 +1569,10 @@ rte_tm_hierarchy_commit(uint16_t port_id,
/**
* Traffic manager node parent update
*
+ * This function may be used to move a node and its children to a different
+ * parent. Additionally, if the new parent is the same as the current parent,
+ * this function will update the priority/weight of an existing node.
+ *
* Restriction for root node: its parent cannot be changed.
*
* This function can only be called after the rte_tm_hierarchy_commit()
--
2.6.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function
2018-07-10 15:33 [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function Ben Shelton
@ 2018-07-31 15:05 ` Thomas Monjalon
2018-07-31 15:09 ` Dumitrescu, Cristian
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-07-31 15:05 UTC (permalink / raw)
To: Cristian Dumitrescu; +Cc: dev, Ben Shelton
Cristian, review please?
10/07/2018 17:33, Ben Shelton:
> The node parent update API function may be used to update the
> priority/weight of an existing node. Update the documentation to
> indicate that this use case is supported.
>
> Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
[...]
> /**
> * Traffic manager node parent update
> *
> + * This function may be used to move a node and its children to a different
> + * parent. Additionally, if the new parent is the same as the current parent,
> + * this function will update the priority/weight of an existing node.
> + *
> * Restriction for root node: its parent cannot be changed.
> *
> * This function can only be called after the rte_tm_hierarchy_commit()
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function
2018-07-31 15:05 ` Thomas Monjalon
@ 2018-07-31 15:09 ` Dumitrescu, Cristian
2018-07-31 16:52 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Dumitrescu, Cristian @ 2018-07-31 15:09 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Shelton, Benjamin H
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, July 31, 2018 4:06 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Shelton, Benjamin H <benjamin.h.shelton@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent
> update API function
>
> Cristian, review please?
>
> 10/07/2018 17:33, Ben Shelton:
> > The node parent update API function may be used to update the
> > priority/weight of an existing node. Update the documentation to
> > indicate that this use case is supported.
> >
> > Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> [...]
> > /**
> > * Traffic manager node parent update
> > *
> > + * This function may be used to move a node and its children to a
> different
> > + * parent. Additionally, if the new parent is the same as the current
> parent,
> > + * this function will update the priority/weight of an existing node.
> > + *
> > * Restriction for root node: its parent cannot be changed.
> > *
> > * This function can only be called after the rte_tm_hierarchy_commit()
>
>
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function
2018-07-31 15:09 ` Dumitrescu, Cristian
@ 2018-07-31 16:52 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-07-31 16:52 UTC (permalink / raw)
To: Shelton, Benjamin H; +Cc: dev, Dumitrescu, Cristian
31/07/2018 17:09, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >
> > Cristian, review please?
> >
> > 10/07/2018 17:33, Ben Shelton:
> > > The node parent update API function may be used to update the
> > > priority/weight of an existing node. Update the documentation to
> > > indicate that this use case is supported.
> > >
> > > Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> > [...]
> > > /**
> > > * Traffic manager node parent update
> > > *
> > > + * This function may be used to move a node and its children to a
> > different
> > > + * parent. Additionally, if the new parent is the same as the current
> > parent,
> > > + * this function will update the priority/weight of an existing node.
> > > + *
> > > * Restriction for root node: its parent cannot be changed.
> > > *
> > > * This function can only be called after the rte_tm_hierarchy_commit()
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-31 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-10 15:33 [dpdk-dev] [PATCH] ethdev: Clarify usage of TM node parent update API function Ben Shelton
2018-07-31 15:05 ` Thomas Monjalon
2018-07-31 15:09 ` Dumitrescu, Cristian
2018-07-31 16:52 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).