From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id CF81E95D6 for ; Mon, 7 Dec 2015 15:46:23 +0100 (CET) Received: by wmvv187 with SMTP id v187so169901957wmv.1 for ; Mon, 07 Dec 2015 06:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=aPTtBb77+ir0WglvoVxC9gqHHBSVUFsdQ/FvbiUz0o0=; b=c3+5XeleGxbQEGnEUQM6TxpFuSyzoQbbmW1dN9JbgjJiqOxQ7sX8WPhiYZFu1zW0qP oZaICH2xEj7ryOEGkhVUMaljUyo8Fbt56r0oywW/k4+awwciXUMB0hKluZR547Or7VNY eAHB4YhR0PAsOqswH2Cc9pJ1wEFGmHEDFCKC0nyE+d7zhG44i5tMzYZ7GSNUmJN/gVP/ z4Yz2xhLoxD6ECoCvZpauyE/twebR/XlZIHtEdJzyVP77e56eiCh+ghRcZU1O2XRNddl 9dL+EHphzQu7wMjM001u0C+S2fEFGaM6iAzdiljzpYatzhaSV2D+dq0fzRfRFHXjtv30 MRQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=aPTtBb77+ir0WglvoVxC9gqHHBSVUFsdQ/FvbiUz0o0=; b=EQr5eKQS7WjqkAIYz8q1fGH7fF/a1g2U5jmuI3XwFABthP5l0Fr1FY4Viml8mKGN7Y 14T0ZKO9USg4fOrpMjA8HAlJM5cZpaTVEnG2Er3pk4A/KjdubC5yY3ztiEvpfKtwgS8W dATFkaTfOVqVe99aEjrw47BFtgL/dvBy+gk5a1j4CJvzw0vNN5JQJktA5KBVckggqQib bUlgaP/hqit3ryWmkDWVK2MJ97ZT2nfMuq7DZIE2jaGEGSdBG72INWYoHY016Vm2N8e8 /C/bpqvhNYbOynhhaUrrSP4bu9srnUGhlUfh4c1hQk37SSGExdFZx0Nt3WHGXPYraWpk hSTA== X-Gm-Message-State: ALoCoQlKztTg5obDgKNVfwrNwyJFKT5jNW7DuzUzjk5B0EvO160/56XSmimuTpsWoPVqgSEg5FKgNmD5k/3KEeR9O0Zw1RZbzg== X-Received: by 10.28.73.11 with SMTP id w11mr20688264wma.44.1449499583684; Mon, 07 Dec 2015 06:46:23 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id t194sm16915297wmt.11.2015.12.07.06.46.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Dec 2015 06:46:23 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Date: Mon, 07 Dec 2015 15:45:10 +0100 Message-ID: <1750446.FDPWrLgo55@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> References: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 14:46:24 -0000 2015-12-07 19:52, Jerin Jacob: > by default, all the targets will be configured with the 64-byte cache line > size, targets which have different cache line size can be overridden > through target specific config file. > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > based on existing configuration. > > Signed-off-by: Jerin Jacob It looks good. We are moving from a constant defined on CC command line in most cases to a constant included in rte_config.h only. Have you checked that the generated libraries are identical? It would be good to have a check for POWER8. Chao? Thanks