From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C6C9A0A0C; Wed, 4 Aug 2021 16:18:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C62364123E; Wed, 4 Aug 2021 16:18:45 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id D89444014F for ; Wed, 4 Aug 2021 16:18:43 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8D9B35C00EB; Wed, 4 Aug 2021 10:18:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 04 Aug 2021 10:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 7SUmD4WL68A5mzqZ4TJoLXK58hJ1dChQ9VG2k2Ithvo=; b=PvD1/VJysbZy0yNk DaaKusOjB82qvGClClLote6cg28n070rVJqMlT98IY9YXmwtz64jhJMBeJE3RL/7 cIwyfseVFxaoveM+BoA8nvtyfbt57QLVI+CxuDajSSwpKlRwGAjuQVB67RTO8ygA eVBFAoHcIElzusJPCkMFvkHO/CBd7z+LI8VmDT9BGgmlfjUzXySXvyy/gfhRO/uq /1eJ7qf3NygA7ZQZBYlrvpjsNCmLfE2E6ZqcRxFYOXOU89dtciXGb6kZALeRRhA1 JfHjbESGcfoyl4MEsP/w3b7ZHIKzxBCkm1V45PNSW4EoghOq22b8pzNUNx6B+sBu zjqOxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=7SUmD4WL68A5mzqZ4TJoLXK58hJ1dChQ9VG2k2Ith vo=; b=oR7eQGoiwcZaL1ZqFuFtK89ZTLa+V86PAc3Kxi5Fd7H1vN5+hl2IY1DKY 5QdfXEVJL0Bhsu/+eJq3Gyh328xIt5wYk6lsbjaQsMw4UDU2BXmKREo6a+g49HxM utPm0CIbQr+8tCZ7h20PSUPXBHRVHpY5Va7Hlo8oQFiBZJq92lQL2+GhkZN1R2Hg JkwC6Hjh78Z6lamJi0MC1y+8mYOzMsF1AKl8/ryYyIZsCqyjMiI0kIBASrSKK4gT 5hAsoTSiaRJUbdVXiGVqHQQae9szfPRQJDQ20KjWz5dklZLgXQgtgmn5KfAkJKGD 0LIFHy/WddsuECTDF8LroZhoN+7cw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieejgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Aug 2021 10:18:41 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: Andrew Rybchenko , dev@dpdk.org, Ray Kinsella , Ajit Khaparde Date: Wed, 04 Aug 2021 16:18:40 +0200 Message-ID: <17508584.7bMJMxF5BA@thomas> In-Reply-To: References: <20210730155700.32574-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > The mbuf offload flags do not match the DPDK namespace (they are > > > not prefixed by RTE_). Announce their rename in 21.11, and the > > > removal of the old names in 22.11. > > > > > > A draft coccinelle script is provided to anticipate what the > > > renaming will be. > > > > > > Signed-off-by: Olivier Matz > > > > Acked-by: Andrew Rybchenko > > > > [snip] > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > > index 9584d6bfd7..04cb141de7 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > +* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``. > > > + A compatibility layer will be kept until DPDK 22.11, except for the flags > > > + that are already deprecated (ex: ``PKT_RX_L4_CKSUM_BAD``), which will > > > + be removed. > > > > I think it is better to be explicit with defines to be removed: > > PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, PKT_TX_QINQ_PKT, > > PKT_RX_EIP_CKSUM_BAD. > +1 > Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon Applied with suggested changes.