From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94D09A0524; Fri, 5 Feb 2021 19:24:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C2DC40682; Fri, 5 Feb 2021 19:24:15 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 3C0714067B for ; Fri, 5 Feb 2021 19:24:14 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 611F45C017E; Fri, 5 Feb 2021 13:24:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 05 Feb 2021 13:24:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= +FiF6u+1SCO8U0kKrukeW3MmC6p3zuo1Q7kXLYBCZLY=; b=CNhhepqgK8Y+uAdw E1SJLnuyikRvy47XoMEJDkBi6HE/yetBPY1r8GIAMOf1m43yP9+Xtb585uGmykfU 3PJ8oDCQeYxPHXQsylOcNa2qGAz9nezVaq6ygJrOduaHWtv7NlAf5u73XTvrR8Og oqXVBL9W2Oo4TX+0i+8Kfs7T9XZOAp28n7yukDbnE7EyMfrDyo4OPG7ZtdQYUeLA o1ijLzCVuK79FOgsLTfihcDXWcUhVMCLa8vt/nT8IKJQ4lgtl5jDyhwS/TXPMC8H goicKuAcjD07RHGeiG3+WcK97NFRi1fZpuOvbB0wIF6TwuZ2OReoWOtdbb33EV1y 2HZ1hw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+FiF6u+1SCO8U0kKrukeW3MmC6p3zuo1Q7kXLYBCZ LY=; b=sz6bujVxVyFahPzUQDGxEcw01ypyDZvMWyAd4ZX6i6P08JTLMfqlDung5 mJUYhMMnKus2l9ofTekON6lUx3okQUXCYTiJltap/fapwvg4vTIkeIg+f9TiBdZL qxofJReEFy2dcJzn4iXeiVE8g4gENcH78Jie5flGhdyXlvx29AubQnSSAV3OlqFu 9Ol8l6huRu4JcuMs5g8KROY+RKENdLA/nn67b0jQHyHxuL9bM7EN2y4b68r7T2mw UpvOdh1oYqqRI9F5H4X92VQHVU0I0TfUHzjXd/L9/qZyF7j3XO4xMQsIT/aEvlsS PNTT+rdgYFpz8xZX9f5qF8qhp5c5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeigdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 12F671080059; Fri, 5 Feb 2021 13:24:11 -0500 (EST) From: Thomas Monjalon To: Sarosh Arif Cc: sthemmin@microsoft.com, dev@dpdk.org, stephen@networkplumber.org Date: Fri, 05 Feb 2021 19:24:10 +0100 Message-ID: <1752015.tdlpT8OkTY@thomas> In-Reply-To: <20210108090627.17365-1-sarosh.arif@emumba.com> References: <20201130124533.23341-1-sarosh.arif@emumba.com> <20210108090627.17365-1-sarosh.arif@emumba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [v3 PATCH] usertools: show an error message if unable to reserve requested hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/01/2021 10:06, Sarosh Arif: > Sometimes the system is unable to reserve the requested hugepages because > enough space is not available in the RAM. In that case, currently the > script displays no error message hence the user can be under the delusion > that the hugepages requested are all successfully reserved. This patch > displays an error message if the pages reserved are different from the > requested pages. > > Signed-off-by: Sarosh Arif > --- > v2: > use a global variable SHOW_HUGEPAGES to remove linter warnings > v3: > only print an error message if unable to reserve hugepages. > --- > + if get_hugepages(path) != pages: > + sys.exit("Unable to reserve required pages.") Replaced double quotes by simple ones. Applied, thanks.