From: Thomas Monjalon <thomas@monjalon.net>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
Cc: Prince Takkar <ptakkar@marvell.com>,
Shivah Shankar Shankar Narayan Rao <sshankarnara@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, Anup Prabhu <aprabhu@marvell.com>,
Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: Re: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues
Date: Thu, 16 Mar 2023 18:07:21 +0100 [thread overview]
Message-ID: <1752339.VLH7GnMWUR@thomas> (raw)
In-Reply-To: <CO6PR18MB39391E0FD6E1226DE0F90543AEBC9@CO6PR18MB3939.namprd18.prod.outlook.com>
16/03/2023 18:02, Srikanth Yalavarthi:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: 16 March 2023 22:30
> > To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > Cc: Prince Takkar <ptakkar@marvell.com>; Shivah Shankar Shankar Narayan
> > Rao <sshankarnara@marvell.com>; dev@dpdk.org; Anup Prabhu
> > <aprabhu@marvell.com>
> > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > 16/03/2023 10:33, Srikanth Yalavarthi:
> > > Added checks for null pointers. Removed logically dead code.
> > > Fix division or modulo by zero. Fix evaluation order violation issues.
> > > Fix potential memory leak in xstats function.
> >
> > I think it would be better to split this patch a little, so we can easily see what
> > are the reasons for the changes.
>
> Separate patch for each Coverity issue?
Maybe yes.
Or try to group similar causes.
next prev parent reply other threads:[~2023-03-16 17:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:54 [PATCH " Srikanth Yalavarthi
2023-03-16 9:33 ` [PATCH v2 " Srikanth Yalavarthi
2023-03-16 17:00 ` Thomas Monjalon
2023-03-16 17:02 ` [EXT] " Srikanth Yalavarthi
2023-03-16 17:07 ` Thomas Monjalon [this message]
2023-03-16 21:28 ` [PATCH v3 0/8] Fixes to ml/cnxk driver Srikanth Yalavarthi
2023-03-16 21:28 ` [PATCH v3 1/8] ml/cnxk: fix evaluation order violation issues Srikanth Yalavarthi
2023-03-16 21:28 ` [PATCH v3 2/8] ml/cnxk: fix potential division by zero Srikanth Yalavarthi
2023-03-16 21:28 ` [PATCH v3 3/8] ml/cnxk: add pointer check after memory allocation Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 4/8] ml/cnxk: remove logically dead code Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 5/8] ml/cnxk: fix potential memory leak in xstats Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 6/8] ml/cnxk: check for null pointer before dereference Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 7/8] ml/cnxk: avoid variable name reuse in a function Srikanth Yalavarthi
2023-03-16 21:29 ` [PATCH v3 8/8] ml/cnxk: reduce levels of nested variables access Srikanth Yalavarthi
2023-03-19 19:01 ` [PATCH v3 0/8] Fixes to ml/cnxk driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1752339.VLH7GnMWUR@thomas \
--to=thomas@monjalon.net \
--cc=aprabhu@marvell.com \
--cc=dev@dpdk.org \
--cc=ptakkar@marvell.com \
--cc=sshankarnara@marvell.com \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).