From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 748B64F93; Wed, 27 Mar 2019 23:42:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0F003220D3; Wed, 27 Mar 2019 18:42:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 18:42:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qqW+gmq9K5dcJqYzSuB4tRiDHFfsyZv0mBSnARQ+CAg=; b=oXpNkli2I/hR S8zJYCZ6UQPW6et0C3Z1KdFqff4AqcSSg79zm/iFT9NHX7R6fGfGheScfX8YMgJb c1M18NT5pI6eeYrrgk3JwDcTrsulkr+fpXu97rhGSPlUWSv8YeOfVh58Y0Y9Wpv/ IVL+vXQcIXe0fgxopFHzpRdsvqRzwNs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qqW+gmq9K5dcJqYzSuB4tRiDHFfsyZv0mBSnARQ+C Ag=; b=ZUBlmhjNpOR08nBgjUDlWDHAliYHu9JrRHCjcvOA99AOG7U+zdzYJGYrL 5ePLyorKXW/DOb9AA6WpcrzG5U/3vaFrTF62QHRmJgVKndnXbyBgd+EtlID5bMI4 fRSQY1qr7WmC6nmnNv9KeS8zwpHpej/OT3GwFLZPyAX2h1zCWuKZOuf0dNOTCr0u cjo8YwY9Xx59KothkgTFM/CoRPu/crOoJkJHty1OMdnxFpUi4mPcdnpNP308D6FZ p408Y+T0cP9xp2p2Iij4IzfRgtDz3l0OAa7tEeNP/rPzzvueFYz9cyXu2m82fdy1 iUf5EjqUpnC2x2k9ljBXj/Yq6UX2Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4A7D7E408B; Wed, 27 Mar 2019 18:42:42 -0400 (EDT) From: Thomas Monjalon To: "Stojaczyk, Dariusz" Cc: "dev@dpdk.org" , "Zhang, Qi Z" , "Burakov, Anatoly" , "stable@dpdk.org" , bruce.richardson@intel.com Date: Wed, 27 Mar 2019 23:42:40 +0100 Message-ID: <1752426.1oQredii45@xps> In-Reply-To: References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com> <2545420.xP4CxeWPSp@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 22:42:44 -0000 27/03/2019 21:33, Stojaczyk, Dariusz: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 26/03/2019 19:43, Darek Stojaczyk: > > > We currently initialize rte_alarms after starting > > > to listen for IPC hotplug requests, which gives > > > us a data race window. Upon receiving such hotplug > > > request we always try to set an alarm and this > > > obviously doesn't work if the alarms weren't > > > initialized yet. > > > > > > To fix it, we initialize alarms before starting > > > to listen for IPC hotplug messages. Specifically, > > > we move rte_eal_alarm_init() right after > > > rte_eal_intr_init() as it makes some sense to > > > keep those two close to each other. > > > > I wonder which regression it will bring :) > > The experience shows that we cannot touch this function > > without introducing a regression. Please check twice. > > Hah, ok - I'll check again the possible outcomes of this. > > > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > > Cc: Qi Zhang > > > Cc: Anatoly Burakov > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Darek Stojaczyk > > > --- > > > lib/librte_eal/linux/eal/eal.c | 12 ++++++------ > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > You probably need to update the FreeBSD version too. > > > > Oh, that I cannot do. First of all, in bsd code I don't see > rte_mp_dev_hotplug_init() called anywhere, as if bsd > did not listen for IPC hotplug messages at all and hence did > not have any data race in this area. Second, I would be > afraid to touch any bsd code as I'm not running any bsd > system. The problem is the consistency between OSes. May you ask help here? Bruce is maintaining the FreeBSD side. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9C77FA05D3 for ; Wed, 27 Mar 2019 23:42:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CCFB5398; Wed, 27 Mar 2019 23:42:45 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 748B64F93; Wed, 27 Mar 2019 23:42:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0F003220D3; Wed, 27 Mar 2019 18:42:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 18:42:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qqW+gmq9K5dcJqYzSuB4tRiDHFfsyZv0mBSnARQ+CAg=; b=oXpNkli2I/hR S8zJYCZ6UQPW6et0C3Z1KdFqff4AqcSSg79zm/iFT9NHX7R6fGfGheScfX8YMgJb c1M18NT5pI6eeYrrgk3JwDcTrsulkr+fpXu97rhGSPlUWSv8YeOfVh58Y0Y9Wpv/ IVL+vXQcIXe0fgxopFHzpRdsvqRzwNs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qqW+gmq9K5dcJqYzSuB4tRiDHFfsyZv0mBSnARQ+C Ag=; b=ZUBlmhjNpOR08nBgjUDlWDHAliYHu9JrRHCjcvOA99AOG7U+zdzYJGYrL 5ePLyorKXW/DOb9AA6WpcrzG5U/3vaFrTF62QHRmJgVKndnXbyBgd+EtlID5bMI4 fRSQY1qr7WmC6nmnNv9KeS8zwpHpej/OT3GwFLZPyAX2h1zCWuKZOuf0dNOTCr0u cjo8YwY9Xx59KothkgTFM/CoRPu/crOoJkJHty1OMdnxFpUi4mPcdnpNP308D6FZ p408Y+T0cP9xp2p2Iij4IzfRgtDz3l0OAa7tEeNP/rPzzvueFYz9cyXu2m82fdy1 iUf5EjqUpnC2x2k9ljBXj/Yq6UX2Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeefgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4A7D7E408B; Wed, 27 Mar 2019 18:42:42 -0400 (EDT) From: Thomas Monjalon To: "Stojaczyk, Dariusz" Cc: "dev@dpdk.org" , "Zhang, Qi Z" , "Burakov, Anatoly" , "stable@dpdk.org" , bruce.richardson@intel.com Date: Wed, 27 Mar 2019 23:42:40 +0100 Message-ID: <1752426.1oQredii45@xps> In-Reply-To: References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com> <2545420.xP4CxeWPSp@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: initialize alarms early X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327224240.POzqk_22-xFr6Z3lE-n0f098XGs79073tnK2wXXHDgM@z> 27/03/2019 21:33, Stojaczyk, Dariusz: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 26/03/2019 19:43, Darek Stojaczyk: > > > We currently initialize rte_alarms after starting > > > to listen for IPC hotplug requests, which gives > > > us a data race window. Upon receiving such hotplug > > > request we always try to set an alarm and this > > > obviously doesn't work if the alarms weren't > > > initialized yet. > > > > > > To fix it, we initialize alarms before starting > > > to listen for IPC hotplug messages. Specifically, > > > we move rte_eal_alarm_init() right after > > > rte_eal_intr_init() as it makes some sense to > > > keep those two close to each other. > > > > I wonder which regression it will bring :) > > The experience shows that we cannot touch this function > > without introducing a regression. Please check twice. > > Hah, ok - I'll check again the possible outcomes of this. > > > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > > Cc: Qi Zhang > > > Cc: Anatoly Burakov > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Darek Stojaczyk > > > --- > > > lib/librte_eal/linux/eal/eal.c | 12 ++++++------ > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > You probably need to update the FreeBSD version too. > > > > Oh, that I cannot do. First of all, in bsd code I don't see > rte_mp_dev_hotplug_init() called anywhere, as if bsd > did not listen for IPC hotplug messages at all and hence did > not have any data race in this area. Second, I would be > afraid to touch any bsd code as I'm not running any bsd > system. The problem is the consistency between OSes. May you ask help here? Bruce is maintaining the FreeBSD side.