From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B036A4C99 for ; Mon, 22 Oct 2018 09:30:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3E0A3226B6; Mon, 22 Oct 2018 03:30:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 03:30:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FRo6kins0/zX1+FTzkcSemS1TOrSYgzV0NktCLC3h0U=; b=TAHGaLysLmij ktVxw0HMBOJLiGoJehPPPfNSbguuAy03pJ9G9AEffiUBfMTsW6JfTtm9Gg5qgOtr E3KSEIcnfN1Z0PlNqtIY1jO2jm+CONROYx9QCtxlPGUMciG4qIDYeZM5smP4z4Kf gxnbEYcMC2mHypw+9NXTIyqlP+C1ZpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FRo6kins0/zX1+FTzkcSemS1TOrSYgzV0NktCLC3h 0U=; b=USbJTm6nel2jk1hqYkQsVeC5glYMgKWigWKiMcE+pXer36Gt11vNE2Yx/ 8X/R5wOU1edaMObzCw1r6H1nR0GahmSduSXp8to8wLjLYlzmLlqehVr1h4axBmLe 64mE3xLOGrga82T2le79YOPPpn4NQg0lMIPG1RebeWHJph3drteKSs3iNb4En2wL M4XIJC1ZhzJNaVVZIM+jOZ6TeugkXopvTPqjZI6gZrNDw8RcbwacfRIyTuiUCVOw CXOljxEXE/S+RDuIII3iP70QFdAVGgZn51vih6j34Q1bYCUFy5q3KiUcZHPhnAhR MXcvxY4Rmxls3y66gnOteUMsknEHw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F5B1102EC; Mon, 22 Oct 2018 03:30:11 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org Date: Mon, 22 Oct 2018 09:30:12 +0200 Message-ID: <1754125.JGkyPi735h@xps> In-Reply-To: <20181022061516.45912-1-qi.z.zhang@intel.com> References: <20181022061516.45912-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix NULL device argument pointer reference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 07:30:12 -0000 22/10/2018 08:15, Qi Zhang: > dev->devargs is not initialized for PCI device, so use dev->bus to > replace dev->devargs->bus to avoid segment fault when hotplug remove > a PCI device. It is not really specific to PCI device. The devargs is not initialized if the device is probed by default policy (i.e. not in blacklist). I think we can say that "devargs is not always initialized". > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > Signed-off-by: Qi Zhang