From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id DDF0E1094 for ; Mon, 27 Mar 2017 23:33:39 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id l43so76312304wre.1 for ; Mon, 27 Mar 2017 14:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=EO5mEsgENCPMjQSuS7RJBDt15eE3mysPAAqCUqkjDps=; b=uCO0qlm81QvEPp2X22dNtoeuisu4IrJmbUYeKJfLPHnhsqD8A+osQWN6zxxKA+GznW DeUuYp1ZLR3yHl8FZtgsNwuakUfS0XWbKkD+92C/uqeN4oiEKhQXwrK0YbxyxWb0fgwE ciRHvcvruWDByl1jXwNjCbbSze7FJQKFCO6voYkGPA6ODpuB8KteJguvwaxXU7opP5uW LWDlCJn3lYT2H3D9V6Sjn5aovTmnEIwCBXkS3ta3zCQDt0z/hnUhNlWTVfKBsUKI/QJi SHOmUTYiodSxC3CsVtrHhZd4Cb+urJzkE33sZmd8g03i5Stdg/ctWYmzk7kz30Cmtvhc qx1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=EO5mEsgENCPMjQSuS7RJBDt15eE3mysPAAqCUqkjDps=; b=lODKcqoWAj7yTUH1Dfn2ynDue/Z6iwmpeR+lRk+4tt171e1M+tIB2o+dSqOD0mdP2d aV3dK2z8kQeT+pLSTmJy3G5Garqub6sSEHwthN6Oj/g6A5BgzmdqfYtAi3OK0sAomk3L PFhFsjJIaZNBEClYTKVDPDVR5Mq0Z/NQyukSEX/XTvQe2aoa4kv3aZJUms1hgyYoPCNO NQ/jp8nTBCV4BQXYQOy2M289V+z9u4fKLJm9ozkZnPUoYeP3iOdRw3aX42wAQ3RHQj7O tQpxgSa1FjqLXPno3TCXOIZocbBZ3Bf0Djyht+8yMTYF+xqq1Cej91Z8syLhacEjWCaI xicA== X-Gm-Message-State: AFeK/H1NzTGzaHmX8++IcyMCNrjKX5jrBZWsX4RtiG8JCnKhKyiAc/dao0XrHQLCoqlPgYhG X-Received: by 10.28.166.133 with SMTP id p127mr11834277wme.62.1490650419646; Mon, 27 Mar 2017 14:33:39 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w2sm972266wmd.19.2017.03.27.14.33.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 14:33:38 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, ferruh.yigit@intel.com, robin.jarry@6wind.com, jerin.jacob@caviumnetworks.com, keith.wiles@intel.com Date: Mon, 27 Mar 2017 23:33:37 +0200 Message-ID: <1754277.1eNtCM3c6t@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170324132131.2187-1-olivier.matz@6wind.com> References: <1489770822-27539-1-git-send-email-olivier.matz@6wind.com> <20170324132131.2187-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: optimize directory dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 21:33:40 -0000 2017-03-24 14:21, Olivier Matz: > Before this patch, the management of dependencies between directories > had several issues: > > - the generation of .depdirs, done at configuration is slow: it can take > more than one minute on some slow targets (usually ~10s on a standard > PC without -j). > > - for instance, it is possible to express a dependency like: > - app/foo depends on lib/librte_foo > - and lib/librte_foo depends on app/bar > But this won't work because the directories are traversed with a > depth-first algorithm, so we have to choose between doing 'app' before > or after 'lib'. > > - the script depdirs-rule.sh is too complex. > > - we cannot use "make -d" for debug, because the output of make is used for > the generation of .depdirs. > > This patch moves the DEPDIRS-* variables in the upper Makefile, making > the dependencies much easier to calculate. A DEPDIRS variable is still > used to process library dependencies in LDLIBS. > > After this commit, "make config" is almost immediate. > > Signed-off-by: Olivier Matz > Tested-by: Robin Jarry > Tested-by: Jerin Jacob It is almost impossible to really review such a big change in Makefiles ;) Fixed a typo in pipeline lib dependency, and Applied, thanks