From: Thomas Monjalon <thomas@monjalon.net>
To: Michael McConville <mmcco@mykolab.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure
Date: Tue, 09 Jan 2018 17:03:46 +0100 [thread overview]
Message-ID: <1754970.MkvYTSaTOZ@xps> (raw)
In-Reply-To: <50ade726-a5bd-2a94-9f8d-ba3f9658d8a3@intel.com>
02/12/2017 01:51, Ferruh Yigit:
> On 12/1/2017 4:50 PM, Ferruh Yigit wrote:
> > On 11/30/2017 10:51 PM, Michael McConville wrote:
> >> Signed-off-by: Michael McConville <mmcco@mykolab.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> >
> > Hi Michael,
> >
> > Thanks you for the patch, can you please check the contribution guide [1] for
> > expected patch format for next patches.
>
> Ahh, there is checkpatch warning as well, can you make a new version of the
> patch with updated patch title and warning fixed?
Fixed and applied, thanks
next prev parent reply other threads:[~2018-01-09 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 6:51 Michael McConville
2017-12-02 0:50 ` Ferruh Yigit
2017-12-02 0:51 ` Ferruh Yigit
2018-01-09 16:03 ` Thomas Monjalon [this message]
2017-12-02 0:54 ` Ferruh Yigit
2017-12-04 7:32 ` Matej Vido
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1754970.MkvYTSaTOZ@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mmcco@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).