Re: [PATCH v3] dts: enable port binding on the TG

[Luca Vizzarro <luca.vizzarro@arm.com>]

Hi Andrew,

Thank you for clarifying. It makes more sense now.

On Thu, Aug 28, 2025 at 08:37:58AM +0000, Andrew Bailey wrote:
> diff --git a/dts/framework/testbed_model/port.py b/dts/framework/testbed_model/port.py
> index fc58e2b993..e9ad145f97 100644
> --- a/dts/framework/testbed_model/port.py
> +++ b/dts/framework/testbed_model/port.py
> @@ -126,7 +126,12 @@ def original_driver(self) -> str | None:
>      @property
>      def bound_for_dpdk(self) -> bool:
>          """Is the port bound to the driver for DPDK?"""
> -        return self.current_driver == self.config.os_driver_for_dpdk
> +        dpdk_driver = self.config.os_driver_for_dpdk
> +
> +        if "TG" in self.node.name:
> +            return self.current_driver == dpdk_driver and dpdk_driver != self.config.os_driver

The `node.name` is an arbitrary name that is chosen by the user.
Unfortunately this is not a reliable approach.

Another issue is that this logic doesn't really make a lot of sense in
the context of this property. I'd much rather have a `bound_for_kernel`
property, and then fix the checks appropriately where these are called.

From my understanding of the commit body this is due to the condition in
the list comprehension in ports_to_bring_up not covering this corner
case. If this is right, then this condition should be updated
accordingly.

> +
> +        return self.current_driver == dpdk_driver
>  
>      def configure_mtu(self, mtu: int):
>          """Configure the port's MTU value.
> diff --git a/dts/framework/testbed_model/topology.py b/dts/framework/testbed_model/topology.py
> index 899ea0ad3a..b35a519719 100644
> --- a/dts/framework/testbed_model/topology.py
> +++ b/dts/framework/testbed_model/topology.py
> @@ -250,6 +253,41 @@ def _bind_ports_to_drivers(
> <snip>
> +        ctx = get_ctx()
> +        prepare_node(ctx.tg_node)
> +        prepare_node(ctx.sut_node)
> +        # ctx.tg_node.main_session.bring_up_link(self.sut_ports)

Like Patrick said, this should be removed.