Re: [dpdk-dev] [PATCH] examples: add a new example for link reset

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-06-08 08:37, Ananyev, Konstantin:
> > From: Ananyev, Konstantin
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > > > Add a new example to show when the PF is down and up, VF port can be
> > > > reset and recover.
> > >
> > > Do we really need a totally new example for it?
> > > Can't we put it in one of already existing ones?
> > > Let say we have l3fwd-vf... wouldn't that suit your needs?
> > > Konstantin
> > I thought about just modifying an existing example. But I choose to add a new one at last. The benefit of a totally new example is we
> > can make it simple enough and focus on the reset function.
> > So it's easier for the users to find what we want to show. And it's also easier for us as we don't need to care about if our modification
> > will break some function of the original example :)
> 
> I still think that adding a new example for esch new feature/function in rte_ethdev API iw way too expensive.
> If your change is not good enough and will break original example, then you probably re-work your feature patch
> to make it stable enough.
> After all people will use it in their existing apps, not write the new ones right?
> BTW, why not make it work with testpmd?
> After all it is a new PMD api, an that's for we have our testpmd here?

+1 for testpmd