From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: enable test_red to build on non x86 platform
Date: Tue, 25 Aug 2015 14:03:13 +0200 [thread overview]
Message-ID: <1759749.jiktJN44xV@xps13> (raw)
In-Reply-To: <1439901605-31164-4-git-send-email-jerin.jacob@caviumnetworks.com>
2015-08-18 18:10, Jerin Jacob:
> --- a/app/test/test_red.c
> +++ b/app/test/test_red.c
> +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
> #ifdef __PIC__
> asm volatile (
> "mov %%ebx, %%edi\n"
> @@ -155,6 +156,7 @@ static inline void rdtsc_prof_start(struct rdtsc_prof *p)
> #else
> asm( "cpuid" : : : "%eax", "%ebx", "%ecx", "%edx" );
> #endif
> +#endif
> p->clk_start = rte_rdtsc();
The right fix would be to move that arch-specific code into an EAL abstraction.
next prev parent reply other threads:[~2015-08-25 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 12:40 [dpdk-dev] [PATCH 0/3] fix build issues with librte_sched, test_red " Jerin Jacob
2015-08-18 12:40 ` [dpdk-dev] [PATCH 1/3] sched: remove unused inclusion of tmmintrin.h Jerin Jacob
2015-08-18 12:40 ` [dpdk-dev] [PATCH 2/3] app/test: test_sched: fix needless build dependency on CONFIG_RTE_ARCH_X86_64 Jerin Jacob
2015-08-18 12:40 ` [dpdk-dev] [PATCH 3/3] app/test: enable test_red to build on non x86 platform Jerin Jacob
2015-08-25 12:03 ` Thomas Monjalon [this message]
2015-08-27 4:08 ` Jerin Jacob
2015-08-27 9:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1759749.jiktJN44xV@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).