Re: [dpdk-dev] [PATCH 2/2] mk: clean up static link with DPAA libraries

[Thomas Monjalon <thomas@monjalon.net>]

23/02/2018 07:25, Hemant Agrawal:
> Hi Thomas,
> On 2/23/2018 4:23 AM, Thomas Monjalon wrote:
> > The bus and mempool dependencies should be declared after the PMD
> > libraries needing them.
> > 
> > Moreover there is no need to disable the PMDs at the Makefile level,
> > in case the dependencies are not met.
> > Such dependencies should be handled at configuration time.
> > 
> > The other side effect of this clean-up is to take into account
> > the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >   mk/rte.app.mk | 20 ++++----------------
> >   1 file changed, 4 insertions(+), 16 deletions(-)
> 
> This patch looks good, however I think we (NXP) need to also set some 
> dependency check in makefile to avoid dpaaX PMD compilations, if bus is 
> not available. I am working on a patch for the same.

Why do you think such check is necessary?
If the PMD is enable but not the bus, it is a configuration error.
A good configuration system would resolve it automatically,
but currently we do the configuration manually, so the user must fix
its configuration file.