From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C41D0288C for <dev@dpdk.org>; Fri, 23 Feb 2018 10:26:24 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1E9E420DB9; Fri, 23 Feb 2018 04:26:24 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 23 Feb 2018 04:26:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=vzZnojPiQcrQarQMv134+e4l5J dU4eHxwkihFWgasU0=; b=N5o6nlVApyRle86WqBcxU6ECM7WmoScezVfCW8enLo 8mLEwjVL/ZZdP6ev5Ra/sPuSzJXMktOgjtqDbW5jRuv6HfE9LgbsOEQiLGVhJewJ Jd2gc2DftXbgV2CgGnSSlnWV8fIq8ZSXUvtnd0Xm00cHetNbvDpYSJR3/RQY2taa M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=vzZnoj PiQcrQarQMv134+e4l5JdU4eHxwkihFWgasU0=; b=Li4Vav3FwALo54svye5OPZ LnDqIRa4vn96xpmgneAKySEJLkvAljQMq8x3Wo7WocS5NySl61+bvb665OcBeV+f DGhWE9ElpKtZ0oYzBxeBWpkOe6klWnPyxYkqMYhRTzEx1gXIzUlTOQFsROfp/cQh 6b3sXb34c32Vt7dr32Sf/tyZI2WLmcuvyuZ42W6VfiwxmhSe/Kdlabx06u5dhIgN HIFsf49skWqmm9gt1rX/Wl/FvbqbNkJkbWrcKEn0j57EzHzWZKCx/+FeOe/sdlPO +Xq7gouyb0dVmdcgAz+uqhMy+4SSAmDxpUgd+fWEN3HjUcedN44Z/Rc1h418yXPQ == X-ME-Sender: <xms:QN6PWmOIYG1coPtd3NkiJ8sOsmEJYw-x6w6uM_mWlKOvYNiaEUGzpg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CB045243C4; Fri, 23 Feb 2018 04:26:23 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Hemant Agrawal <hemant.agrawal@nxp.com> Cc: dev@dpdk.org, mvarlese@suse.de Date: Fri, 23 Feb 2018 10:25:57 +0100 Message-ID: <1759755.H60iFR18bq@xps> In-Reply-To: <b5a1d866-c4c9-6b40-3eb6-8afed2fa4c21@nxp.com> References: <1519329652.2458.5.camel@suse.de> <20180222225308.16972-2-thomas@monjalon.net> <b5a1d866-c4c9-6b40-3eb6-8afed2fa4c21@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] mk: clean up static link with DPAA libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 23 Feb 2018 09:26:25 -0000 23/02/2018 07:25, Hemant Agrawal: > Hi Thomas, > On 2/23/2018 4:23 AM, Thomas Monjalon wrote: > > The bus and mempool dependencies should be declared after the PMD > > libraries needing them. > > > > Moreover there is no need to disable the PMDs at the Makefile level, > > in case the dependencies are not met. > > Such dependencies should be handled at configuration time. > > > > The other side effect of this clean-up is to take into account > > the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL. > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > mk/rte.app.mk | 20 ++++---------------- > > 1 file changed, 4 insertions(+), 16 deletions(-) > > This patch looks good, however I think we (NXP) need to also set some > dependency check in makefile to avoid dpaaX PMD compilations, if bus is > not available. I am working on a patch for the same. Why do you think such check is necessary? If the PMD is enable but not the bus, it is a configuration error. A good configuration system would resolve it automatically, but currently we do the configuration manually, so the user must fix its configuration file.