DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	gaetan.rivet@6wind.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file
Date: Mon, 16 Mar 2020 15:30:32 +0100	[thread overview]
Message-ID: <17605200.jiFIW2sfyF@xps> (raw)
In-Reply-To: <20200316112951.35428-1-bruce.richardson@intel.com>

16/03/2020 12:29, Bruce Richardson:
> The rte_pci.h file includes more header files than are actually needed,
> which means that all users of it also include those headers. This patch
> removes the unneeded headers - adding them elsewhere where other components
> were requiring them but not including them directly.
> 
> Fixes: c752998b5e2e ("pci: introduce library and driver")
> Cc: gaetan.rivet@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
[...]
> --- a/lib/librte_pci/rte_pci.h
> +++ b/lib/librte_pci/rte_pci.h
> -#include <stdio.h>
>  #include <stdlib.h>
>  #include <limits.h>
> -#include <errno.h>
>  #include <sys/queue.h>
> -#include <stdint.h>
>  #include <inttypes.h>
>  
> -#include <rte_debug.h>
> -#include <rte_interrupts.h>

Removing useless includes (or lines in general) is always good.

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks



  reply	other threads:[~2020-03-16 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 11:29 Bruce Richardson
2020-03-16 14:30 ` Thomas Monjalon [this message]
2020-03-16 17:49 ` David Christensen
2020-03-16 19:07   ` David Christensen
2020-03-19  8:10     ` David Marchand
2020-03-20 13:25       ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17605200.jiFIW2sfyF@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).