From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A63EA0559; Mon, 16 Mar 2020 15:30:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4DED1C025; Mon, 16 Mar 2020 15:30:37 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 217602BF9; Mon, 16 Mar 2020 15:30:36 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BCDB85C0370; Mon, 16 Mar 2020 10:30:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 16 Mar 2020 10:30:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=uNG3SeHb5JYnPxPhrN4ogY8Egh8At6oUmWtQ4Xfhork=; b=ATHBM4YMGpzq /ZvkPO/n+qwfw7kL9zb0EIz5i3tRVfnhdSpMevZgdfr+WC4lq7RAXDlwzovHqbN/ eyee3G7nDr9be0XgZUnYw5QOgEYRt30DClMLvQ5GJ2Gp/YzU6pj69A/ilGk5c6p4 ks0lGjyzIpkx3AqLkK1xbg/hRSDyXbk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uNG3SeHb5JYnPxPhrN4ogY8Egh8At6oUmWtQ4Xfho rk=; b=ORpwSzTu2o0qTLJPzpwpl9sr6FMRNlJ3W7OxUx+NQ8wOYy3WIflloXWfj lEQnqjRORAwbE12GUYnoioSy/akLSF9F7XEqo88j0/eb4pZUmAeqe7jh6B0GW/2R VgrRqHym2WxUcSTJJhtr35IiLodWnvCsJxigL87GszmSSjbm3GHWDETQQ3OlS3UD dv2Z/e8BXH5MThR1rKpwb+Ab5RKS/jwb5UdTtjvfoMqPVFc/VZ8E0fzPDghG3LdS YKszy+aHprcG+B+FQX4wMPWE8XzXeq3jBSxfNn6yCoZPTv/0xgHr84mB4sqmAuIl J5kUb+MwRPvEL+8VKNZmCjYdgQ3PQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeffedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BAEFC328005A; Mon, 16 Mar 2020 10:30:34 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Dmitry Kozlyuk , gaetan.rivet@6wind.com, stable@dpdk.org Date: Mon, 16 Mar 2020 15:30:32 +0100 Message-ID: <17605200.jiFIW2sfyF@xps> In-Reply-To: <20200316112951.35428-1-bruce.richardson@intel.com> References: <20200316112951.35428-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/03/2020 12:29, Bruce Richardson: > The rte_pci.h file includes more header files than are actually needed, > which means that all users of it also include those headers. This patch > removes the unneeded headers - adding them elsewhere where other components > were requiring them but not including them directly. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: gaetan.rivet@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson [...] > --- a/lib/librte_pci/rte_pci.h > +++ b/lib/librte_pci/rte_pci.h > -#include > #include > #include > -#include > #include > -#include > #include > > -#include > -#include Removing useless includes (or lines in general) is always good. Acked-by: Thomas Monjalon Applied, thanks